Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1397144

Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where?

From Radim Krčmář <rkrcmar@redhat.com>
Newsgroups linux.kernel
Subject Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where?
Date 2016-05-09 17:30 +0200
Message-ID <rwVia-8if-15@gated-at.bofh.it> (permalink)
References <rvfEm-6ak-7@gated-at.bofh.it> <rvmPB-4Dm-115@gated-at.bofh.it> <rwU2K-7bS-1@gated-at.bofh.it> <rwUFr-7AA-7@gated-at.bofh.it> <rwV8u-8cW-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


2016-05-09 17:15+0200, Paolo Bonzini:
> On 09/05/2016 16:47, Radim Krčmář wrote:
>> 2016-05-09 16:00+0200, Paolo Bonzini:
>>> On 05/05/2016 10:24, Borislav Petkov wrote:
>>>> On Wed, May 04, 2016 at 05:49:27PM -0700, Brooks Moses wrote:
>>>>> When I run "make ARCH=x86 headers_install", and then write a simple C
>>>>> file that #includes "asm/kvm.h" from the resulting tree, I get a
>>>>> compiler error: the BIT() macro used on line 219 of that file is
>>>>> undefined:
>>>>
>>>> The below patch should help...
>>>>
>>>> @Paulo: btw, any chance we can fix that "signifcant" typo :-) in
>>>> KVM_CPUID_FLAG_SIGNIFCANT_INDEX or is it user-visible and cast in
>>>> stone?
>>>
>>> Unfortuntely it is cast in stone.  The patch below is good though.
>> 
>> We can "fix" it by introducing a second name for the entry.  Do you
>> think it's worth?
> 
> I don't think so, but perhaps there are precedents for doing that?

I can't think of any, and it seems pointless to me ...

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Brooks Moses <bmoses@google.com> - 2016-05-05 02:50 +0200
  Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Borislav Petkov <bp@suse.de> - 2016-05-05 10:30 +0200
    Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Brooks Moses <bmoses@google.com> - 2016-05-05 21:20 +0200
    Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Paolo Bonzini <pbonzini@redhat.com> - 2016-05-09 16:10 +0200
      Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Radim Krčmář <rkrcmar@redhat.com> - 2016-05-09 16:50 +0200
        Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Paolo Bonzini <pbonzini@redhat.com> - 2016-05-09 17:20 +0200
          Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Radim Krčmář <rkrcmar@redhat.com> - 2016-05-09 17:30 +0200
            Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Borislav Petkov <bp@suse.de> - 2016-05-09 17:50 +0200

csiph-web