Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions
Date	2016-05-09 17:00 +0200
Message-ID	<rwUP9-7Fi-21@gated-at.bofh.it> (permalink)
References	(1 earlier) <rvpkm-7hg-9@gated-at.bofh.it> <rvN3j-51u-9@gated-at.bofh.it> <rvP58-6Z1-11@gated-at.bofh.it> <rvQuf-8qB-21@gated-at.bofh.it> <rwSaC-5og-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, May 09, 2016 at 12:05:56PM +0000, Opensource [Adam Thomson] wrote:
> On May 06, 2016, 17:06, Mark Brown wrote:

> > No, not really - your DT is fairly unusual in how it's done and the lack
> > of ACPI helpers is not a good sign on that side.  The _DSD things are
> > really only supposed to work for simple properties on devices.

> It's unusual in that there's a child node ("da7219_aad") of the device node, to
> encapsulate AAD specific information. The properties inside though are data only
> and simple. Actually, as I read it this is exactly the kind of thing that the
> 'Hierarchical Data Extension UUID For _DSD' is for.

If it's something that's supposed to be done I'd expect the code to be
cleaner and less driver specific.

> > > The intention was to just match against DT or ACPI and nothing else, so that
> > > didn't feel generic enough to be pushed into the fwnode framework. However
> > > I will take another look.

> > That's currently the entire set of things that fwnode supports so...

> I believe there's the FWNODE_PDATA type as well so 3 things, although I assume
> that this is to be used longer term instead of the old fashioned platform
> data mechanism, for built-in properties. Right now though I don't see much
> actual usage of this.

Well, if you do that you don't need to check if data has been provided
at all.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] ASoC: da7219: Add ACPI initialisation support to driver Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2016-05-05 13:00 +0200
  [PATCH 3/3] ASoC: da7219: Add initial ACPI id for device Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2016-05-05 13:00 +0200
  [PATCH 2/3] ASoC: da7219: Add ACPI parsing support Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2016-05-05 13:00 +0200
    Re: [PATCH 2/3] ASoC: da7219: Add ACPI parsing support Mark Brown <broonie@kernel.org> - 2016-05-06 14:40 +0200
      RE: [PATCH 2/3] ASoC: da7219: Add ACPI parsing support "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2016-05-06 16:50 +0200
        Re: [PATCH 2/3] ASoC: da7219: Add ACPI parsing support Mark Brown <broonie@kernel.org> - 2016-05-06 18:50 +0200
  [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode  functions Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2016-05-05 13:10 +0200
    Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic  device/fwnode functions Mark Brown <broonie@kernel.org> - 2016-05-06 14:30 +0200
      RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic  device/fwnode functions "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2016-05-06 16:40 +0200
        Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic  device/fwnode functions Mark Brown <broonie@kernel.org> - 2016-05-06 18:10 +0200
          RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic  device/fwnode functions "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2016-05-09 14:10 +0200
            Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic  device/fwnode functions Mark Brown <broonie@kernel.org> - 2016-05-09 17:00 +0200

csiph-web