Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1397118

Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors

Show all headers | View raw

On Sun, May 08, 2016 at 06:46:13PM +0000, Verma, Vishal L wrote:
> On Sun, 2016-05-08 at 01:52 -0700, Christoph Hellwig wrote:
> > On Fri, May 06, 2016 at 03:53:09PM -0600, Vishal Verma wrote:
> > > 
> > > From: Matthew Wilcox <matthew.r.wilcox@intel.com>
> > > 
> > > dax_clear_sectors() cannot handle poisoned blocks.  These must be
> > > zeroed using the BIO interface instead.  Convert ext2 and XFS to
> > > use
> > > only sb_issue_zerout().
> > > 
> > > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> > > [vishal: Also remove the dax_clear_sectors function entirely]
> > > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> > Just to make sure:  the existing sb_issue_zerout as in 4.6-rc
> > is already doing the right thing for DAX?  I've got a pending
> > patchset
> > for XFS that introduces another dax_clear_sectors users, but if it's
> > already safe to use blkdev_issue_zeroout I can switch to that and
> > avoid
> > the merge conflict.
> 
> I believe so - Jan has moved all unwritten extent conversions out of
> DAX with his patch set, and I believe zeroing through the driver is
> always fine. Ross or Jan could confirm though. 

Yep, I believe that the existing sb_issue_zeroout() as of v4.6-rc* does the
right thing.  We'll end up calling sb_issue_zeroout() => blkdev_issue_zeroout()
=> __blkdev_issue_zeroout() because we don't have support for discard or
write_same in PMEM.  This will send zero page BIOs to the PMEM driver, which
will do the zeroing as normal writes.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/5] dax: handling media errors (clear-on-zero only) Vishal Verma <vishal.l.verma@intel.com> - 2016-05-07 00:00 +0200
  [PATCH v5 2/5] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma <vishal.l.verma@intel.com> - 2016-05-07 00:00 +0200
  [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma <vishal.l.verma@intel.com> - 2016-05-07 00:00 +0200
    Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling  dax_clear_sectors Christoph Hellwig <hch@infradead.org> - 2016-05-08 11:00 +0200
      Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling  dax_clear_sectors "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-08 20:50 +0200
        Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling  dax_clear_sectors Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-05-09 17:00 +0200
    Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling  dax_clear_sectors Jan Kara <jack@suse.cz> - 2016-05-10 16:20 +0200
  [PATCH v5 5/5] dax: fix a comment in dax_zero_page_range and dax_truncate_page Vishal Verma <vishal.l.verma@intel.com> - 2016-05-07 00:00 +0200
    Re: [PATCH v5 5/5] dax: fix a comment in dax_zero_page_range and  dax_truncate_page Jan Kara <jack@suse.cz> - 2016-05-10 16:30 +0200
  Re: [PATCH v5 0/5] dax: handling media errors (clear-on-zero only) Christoph Hellwig <hch@infradead.org> - 2016-05-08 11:00 +0200

csiph-web