Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount

From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount
Date	2016-05-09 10:40 +0200
Message-ID	<rwOTo-1x9-23@gated-at.bofh.it> (permalink)
References	<rvBYd-2li-7@gated-at.bofh.it> <rvBYh-2li-83@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 05-05-16 18:29:55, Toshi Kani wrote:
> When a partition is not aligned by 4KB, mount -o dax succeeds,
> but any read/write access to the filesystem fails, except for
> metadata update.
> 
> Call bdev_supports_dax() to perform proper precondition checks
> which includes this partition alignment check.
> 
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Boaz Harrosh <boaz@plexistor.com>

Looks good to me. Since this patch depends on the first two in your series,
just feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

and merge it along with other patches. I've removed the ext2 patch from
the previous version from my tree.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 4/5] ext2: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-05-06 02:40 +0200
  Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount Christoph Hellwig <hch@infradead.org> - 2016-05-08 11:00 +0200
    Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount Jan Kara <jack@suse.cz> - 2016-05-09 10:30 +0200
  Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount Jan Kara <jack@suse.cz> - 2016-05-09 10:40 +0200

csiph-web