Re: [PATCH 1/1] usb: net2272: avoid shifting 0

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] usb: net2272: avoid shifting 0
Date	2016-05-09 10:20 +0200
Message-ID	<rwOA2-1jg-11@gated-at.bofh.it> (permalink)
References	<rwF3I-73q-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Heinrich Schuchardt <xypron.glpk@gmx.de> writes:
> Remove redundant code.
> Or'ing with a shifted value of zero is a NOP.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

it sure is and the compiler is getting rid of those. They are there as
means of documentation only ;-)

I really have no strong feelings about this patch, so I'll let the other
folks who have been hacking on this to decide.

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] usb: net2272: avoid shifting 0 Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-05-09 00:10 +0200
  Re: [PATCH 1/1] usb: net2272: avoid shifting 0 Felipe Balbi <balbi@kernel.org> - 2016-05-09 10:20 +0200

csiph-web