Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1396503
| Path | csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Heinrich Schuchardt <xypron.glpk@gmx.de> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/1] USB: FHCI: avoid redundant condition |
| Date | Mon, 09 May 2016 00:20:02 +0200 |
| Message-ID | <rwFdo-77R-11@gated-at.bofh.it> (permalink) |
| X-Mailer | git-send-email 2.1.4 |
| X-Provags-ID | V03:K0:TEj8lWfLjesIhh4TPvHe2VqxpzyAdLJT41yvifHQnd1hfwxeKGo mhXvixpBdknoFht/CSmqEfQa1kwkVzSzUyuJcFAMAIssH8gt5luE53GlQ1PdEbKsV3d1ZzM 5v7gIq+zSEe0vK8BZh0IhWeKodjLhXO80IdDDHD9Xf1nc3pCEUEEbpyXFliIHCYVafjqQpV ppaXOvqBPVK2swdCDwA4w== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:BOr8XJ2oHU0=:JcWqDIBZXSnGI2ElmkvFbv QKBKl1r6fcOmI0mTPC6OtYFfI/1mbRm0mUiVCnSregnrJqIqTyCMlWckmfTGejq/VTn0m9cct ju/DUkT31BgnD39H5wyH91Dv8dFHfD6JOmqIDMYCuoUNph50V9n99CdkNI6NkZZZGx9ArppT5 QDW7fjEUyubnPcVHddZNOteLVg4shPzYkQaLgS4UwzteQ96bZyeY5y84KqioO8ip7tiX02+Mr 2OQ7rzw2G8k6MTGzvySzwPeEZND0VKP0d8NP9UfhhPlMvLXo0ajlvBfE01RLVB88hQiL4sM2K u+YZFSHRVNZ75/O2Gvq62pSKxUn2+qZVik3lpswEwSvYQwnFbwliRcIUzy8Er4eH1uqKX8c4O 5T2gFj4kvYG6YcvQQS9iqWZyVbdKbEf4dlJGxCEie4v8S5zqGzZtKUFsozIn3eshXbGftW5OK 8NBlwVCCbr3bgSok/IHYQAxZg8IJ9SkVM0iP68aFG0YSP6nEl9ZzMMvt1mOsSdJ1kgq3mXAhg bP67ZpmhWh5wpcEqW4RLJpyds+N5UmKAyOJSF1t2soTGYdpPQMFUkH/18SDGZ+QU8iecCXpp4 F56o2PUlJzNICX+MA9Hlwhb5Ihw+vFbfwxs+uS0b0iFosbwuZ4OfMGw3/CI2t0GhPyziwC/TL UOIuuvcKxM1dSTHmYKTLex68ondxthtT0mSHDij98EILd1OqNcuKckAK3v7Wf7qGQFyji3H5q lXJjcAAO2TNI1TZ/aSZUGoaP9OJfaBkZ/44nnQcXPBF2j548YcXTyy/z1ts= |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 25 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Scott Wood <scottwood@freescale.com>, Zhao Qiang <qiang.zhao@freescale.com>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Heinrich Schuchardt <xypron.glpk@gmx.de> |
| X-Original-Date | Mon, 9 May 2016 00:15:31 +0200 |
| X-Original-Message-ID | <1462745731-4864-1-git-send-email-xypron.glpk@gmx.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1396503 |
Show key headers only | View raw
The right part of the following or expression is only evaluated if
td is nonzero.
!td || (td && td.status == USB_TD_INPROGRESS)
So no need to check td again.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/usb/host/fhci-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/fhci-sched.c b/drivers/usb/host/fhci-sched.c
index a9609a3..2f162fa 100644
--- a/drivers/usb/host/fhci-sched.c
+++ b/drivers/usb/host/fhci-sched.c
@@ -288,7 +288,7 @@ static int scan_ed_list(struct fhci_usb *usb,
list_for_each_entry(ed, list, node) {
td = ed->td_head;
- if (!td || (td && td->status == USB_TD_INPROGRESS))
+ if (!td || td->status == USB_TD_INPROGRESS)
continue;
if (ed->state != FHCI_ED_OPER) {
--
2.1.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 1/1] USB: FHCI: avoid redundant condition Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-05-09 00:20 +0200
csiph-web