Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

From	Jon Hunter <jonathanh@nvidia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice
Date	2016-05-05 19:20 +0200
Message-ID	<rvv6q-3V7-1@gated-at.bofh.it> (permalink)
References	<rv6hJ-5S0-45@gated-at.bofh.it> <rv6hJ-5S0-43@gated-at.bofh.it> <rvuWJ-3QF-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/05/16 18:05, Jon Hunter wrote:

[snip]

> I spent a bit of time looking at this to figure out what it is doing. Can we simply 
> this a bit as follows (limited testing so far) ...
> 
> Cheers
> Jon
> 
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index c1c1024a054c..70501053e1ec 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -81,15 +81,25 @@ static int tegra_reset_usb_controller(struct platform_device *pdev)
>         struct usb_hcd *hcd = platform_get_drvdata(pdev);
>         struct tegra_ehci_hcd *tegra =
>                 (struct tegra_ehci_hcd *)hcd_to_ehci(hcd)->priv;
> +       bool has_utmi_pad_registers = false;
> +       dev_info(&pdev->dev, "%s-%d\n", __func__, __LINE__);

Oops, some left over debug I meant to remove :-p
Jon

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice Thierry Reding <thierry.reding@gmail.com> - 2016-05-04 16:50 +0200
  Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same  reset twice Philipp Zabel <p.zabel@pengutronix.de> - 2016-05-04 19:30 +0200
    Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same  reset twice Thierry Reding <thierry.reding@gmail.com> - 2016-05-04 22:20 +0200
  Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same  reset twice Stephen Warren <swarren@wwwdotorg.org> - 2016-05-04 19:30 +0200
    Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same  reset twice Thierry Reding <thierry.reding@gmail.com> - 2016-05-04 22:30 +0200
      Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same  reset twice Hans de Goede <hdegoede@redhat.com> - 2016-05-05 10:10 +0200
        Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same  reset twice Stephen Warren <swarren@wwwdotorg.org> - 2016-05-05 18:10 +0200
          Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same  reset twice Hans de Goede <hdegoede@redhat.com> - 2016-05-05 19:20 +0200
  Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same  reset twice Jon Hunter <jonathanh@nvidia.com> - 2016-05-05 19:10 +0200
    Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same  reset twice Jon Hunter <jonathanh@nvidia.com> - 2016-05-05 19:20 +0200

csiph-web