Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1395068
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] mailbox: Fix devm_ioremap_resource error detection code |
| Date | 2016-05-05 14:30 +0200 |
| Message-ID | <rvqzM-8j6-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. The Coccinelle semantic patch used to make this change is as follows: @@ expression e,e1; statement S; @@ *e = devm_ioremap_resource(...); if (!e1) S Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> --- drivers/mailbox/mailbox-sti.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c index 2394cfe..a334db5 100644 --- a/drivers/mailbox/mailbox-sti.c +++ b/drivers/mailbox/mailbox-sti.c @@ -430,8 +430,8 @@ static int sti_mbox_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); mdev->base = devm_ioremap_resource(&pdev->dev, res); - if (!mdev->base) - return -ENOMEM; + if (IS_ERR(mdev->base)) + return PTR_ERR(mdev->base); ret = of_property_read_string(np, "mbox-name", &mdev->name); if (ret) -- 1.9.1
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] mailbox: Fix devm_ioremap_resource error detection code Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-05-05 14:30 +0200
csiph-web