Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1395061

Re: [PATCH] mm: slab: remove ZONE_DMA_FLAG

From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mm: slab: remove ZONE_DMA_FLAG
Date 2016-05-05 14:00 +0200
Message-ID <rvq6K-7IA-29@gated-at.bofh.it> (permalink)
References <rv8My-8iq-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed 04-05-16 10:01:37, Yang Shi wrote:
> Now we have IS_ENABLED helper to check if a Kconfig option is enabled or not,
> so ZONE_DMA_FLAG sounds no longer useful.
> 
> And, the use of ZONE_DMA_FLAG in slab looks pointless according to the
> comment [1] from Johannes Weiner, so remove them and ORing passed in flags with
> the cache gfp flags has been done in kmem_getpages().
> 
> [1] https://lkml.org/lkml/2014/9/25/553

I haven't checked the patch but I have a formal suggestion.
lkml.org tends to break and forget, please use
http://lkml.kernel.org/r/$msg-id instead. In this case
http://lkml.kernel.org/r/20140925185047.GA21089@cmpxchg.org

Thanks!
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mm: slab: remove ZONE_DMA_FLAG Yang Shi <yang.shi@linaro.org> - 2016-05-04 19:30 +0200
  Re: [PATCH] mm: slab: remove ZONE_DMA_FLAG Michal Hocko <mhocko@kernel.org> - 2016-05-05 14:00 +0200
    Re: [PATCH] mm: slab: remove ZONE_DMA_FLAG "Shi, Yang" <yang.shi@linaro.org> - 2016-05-09 19:30 +0200

csiph-web