Re: [PATCH] rtc: add support for maxim rtc max6916

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: add support for maxim rtc max6916
Date	2016-05-05 13:00 +0200
Message-ID	<rvpaG-6Ru-3@gated-at.bofh.it> (permalink)
References	<rvoxY-6w5-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 05/05/2016 at 03:09:49 -0700, venkat.prashanth2498@gmail.com wrote :
> From: venkat-prashanth <venkat.prashanth2498@gmail.com>
> 
> This a patch to add support for
> maxim rtc max6916
> 
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
> ---
> ---
>  drivers/rtc/rtc-max6916.c | 165 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 165 insertions(+)
> 

This is the second version you send since my comments. Please include
the patch version in the subject line.
Also, you need to include a changelog.
Finally, you didn't address many of my comments please do so before
submitting again.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: add support for maxim rtc max6916 venkat.prashanth2498@gmail.com - 2016-05-05 12:20 +0200
  Re: [PATCH] rtc: add support for maxim rtc max6916 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-05-05 13:00 +0200

csiph-web