Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1394945

[PATCH 07/12] net-next: mediatek: disable all interrupts during probe

From John Crispin <john@phrozen.org>
Newsgroups linux.kernel
Subject [PATCH 07/12] net-next: mediatek: disable all interrupts during probe
Date 2016-05-05 11:30 +0200
Message-ID <rvnLA-5Kz-7@gated-at.bofh.it> (permalink)
References <rvnLA-5Kz-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The current code only disables those IRQs that we will later use. To
ensure that we have a predefined state, we really want to disable all IRQs.
Change the code to disable all IRQs to achieve this.

Signed-off-by: John Crispin <john@phrozen.org>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 60095be..08f3df4 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1391,7 +1391,7 @@ static int __init mtk_hw_init(struct mtk_eth *eth)
 
 	/* disable delay and normal interrupt */
 	mtk_w32(eth, 0, MTK_QDMA_DELAY_INT);
-	mtk_irq_disable(eth, MTK_TX_DONE_INT | MTK_RX_DONE_INT);
+	mtk_irq_disable(eth, ~0);
 	mtk_w32(eth, RST_GL_PSE, MTK_RST_GL);
 	mtk_w32(eth, 0, MTK_RST_GL);
 
-- 
1.7.10.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 07/12] net-next: mediatek: disable all interrupts during probe John Crispin <john@phrozen.org> - 2016-05-05 11:30 +0200

csiph-web