Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal return

From	Yury Norov <ynorov@caviumnetworks.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal return
Date	2016-05-05 10:30 +0200
Message-ID	<rvmPy-4Dm-57@gated-at.bofh.it> (permalink)
References	(1 earlier) <rtkyu-1rQ-3@gated-at.bofh.it> <ruEv7-5nI-3@gated-at.bofh.it> <ruEv7-5nI-1@gated-at.bofh.it> <ruGwW-7bI-13@gated-at.bofh.it> <ruHW3-8fC-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 03, 2016 at 08:41:25PM +0800, Zhangjian (Bamvor) wrote:
[...]

> After apply this patch with my small testcase, the vsyscall of gettimeofday in
> ilp32 works in both big endian and small endian. In this patch, I use the
> different register and offset for ilp32 and lp64. Actually, the
> COMPAT_TVAL_TV_SEC is same as TVAL_TV_SEC(so as to COMPAT_TSPEC_TV_SEC and
> TSPEC_TV_SEC). I add it to keep the logic clear. I also change the version
> of vdso to 4.6. It should change to 2.6.39 if glibc is not update.
> 
> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
> index 574081f..c8e32eb 100644
> --- a/arch/arm64/kernel/asm-offsets.c
> +++ b/arch/arm64/kernel/asm-offsets.c
> @@ -101,6 +101,11 @@ int main(void)
>    DEFINE(TSPEC_TV_SEC,		offsetof(struct timespec, tv_sec));
>    DEFINE(TSPEC_TV_NSEC,		offsetof(struct timespec, tv_nsec));
>    BLANK();
> +  DEFINE(COMPAT_TVAL_TV_SEC,	offsetof(struct compat_timeval, tv_sec));
> +  DEFINE(COMPAT_TVAL_TV_USEC,	offsetof(struct compat_timeval, tv_usec));
> +  DEFINE(COMPAT_TSPEC_TV_SEC,	offsetof(struct compat_timespec, tv_sec));
> +  DEFINE(COMPAT_TSPEC_TV_NSEC,	offsetof(struct compat_timespec, tv_nsec));
> +  BLANK();

Hi Bamvor,

We just found this lines break build if ILP32 is disabled. I think we
need to wrap them with #ifdef CONFIG_ARM64_ILP32

Yury

Thread

Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal  return Catalin Marinas <catalin.marinas@arm.com> - 2016-04-29 18:10 +0200
  Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal return Arnd Bergmann <arnd@arndb.de> - 2016-04-29 19:40 +0200
    Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal return Arnd Bergmann <arnd@arndb.de> - 2016-05-03 11:10 +0200
      Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal  return "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> - 2016-05-03 13:20 +0200
        Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal  return "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> - 2016-05-03 14:50 +0200
          Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal  return Yury Norov <ynorov@caviumnetworks.com> - 2016-05-05 00:00 +0200
            Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal return Andrew Pinski <pinskia@gmail.com> - 2016-05-05 01:30 +0200
              Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal  return "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> - 2016-05-05 04:30 +0200
                Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal return Andrew Pinski <pinskia@gmail.com> - 2016-05-05 08:50 +0200
                Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal  return "Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> - 2016-05-09 12:20 +0200
          Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal  return Yury Norov <ynorov@caviumnetworks.com> - 2016-05-05 10:30 +0200
    Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal  return Catalin Marinas <catalin.marinas@arm.com> - 2016-05-03 11:10 +0200

csiph-web