Re: [PATCH v2 03/15] MIPS: PCI: Compatibility with ARM-like PCI host drivers

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 03/15] MIPS: PCI: Compatibility with ARM-like PCI host drivers
Date	2016-05-05 03:40 +0200
Message-ID	<rvgqL-6Uh-7@gated-at.bofh.it> (permalink)
References	<qY3WV-1lI-5@gated-at.bofh.it> <qY3WX-1lI-57@gated-at.bofh.it> <rib5w-4TO-19@gated-at.bofh.it> <rk9Ck-1sf-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Paul,

On 04/04/16 03:09, Paul Burton wrote:
> Hi Florian,
> 
> Just an FYI, the pcie-xilinx driver I wrote this for has since been
> converted away from the ARM-like pci_common_init_dev & struct hw_pci to
> use only functions provided by the core PCI subsystem[1]. As a result
> I've stopped using this patch & don't plan to continue work on it.
> Perhaps it would be cleanest to do a similar conversion for the driver
> you're using?

Yes, I did just that, but as of v4.6-rc6, I am seeing a bunch of
undefined references while doing so:

arch/mips/pci/built-in.o: In function `pcibios_enable_device':
(.text+0x550): undefined reference to `pcibios_plat_dev_init'
arch/mips/pci/built-in.o: In function `pcibios_init':
pci.c:(.init.text+0x6c): undefined reference to `pcibios_map_irq'
pci.c:(.init.text+0x78): undefined reference to `pcibios_map_irq'

and this makes perfect sense because arch/mips/pci/pci.c is referencing
those functions, while I did not add anything for BMIPS_GENERIC.

At this point, I would very much prefer that the MIPS/Linux kernel did
not rely on the different machines to provide those implementations
(though it definitively is not a big deal to add them, it just feels
unnecessary), I will try to cook a patch for that and provide dummy
fallbacks.

Thanks!
-- 
Florian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 03/15] MIPS: PCI: Compatibility with ARM-like PCI host  drivers Florian Fainelli <f.fainelli@gmail.com> - 2016-05-05 03:40 +0200
  Re: [PATCH v2 03/15] MIPS: PCI: Compatibility with ARM-like PCI host  drivers Paul Burton <paul.burton@imgtec.com> - 2016-05-05 13:10 +0200
    Re: [PATCH v2 03/15] MIPS: PCI: Compatibility with ARM-like PCI host  drivers Florian Fainelli <f.fainelli@gmail.com> - 2016-05-05 19:20 +0200

csiph-web