Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1394762

Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES

From Dave Hansen <dave.hansen@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES
Date 2016-05-05 00:50 +0200
Message-ID <rvdMe-4aR-3@gated-at.bofh.it> (permalink)
References <r92ut-2hO-1@gated-at.bofh.it> <r92uv-2hO-29@gated-at.bofh.it> <rvdMe-4aR-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 05/04/2016 03:41 PM, Dave Hansen wrote:
> But, since we *always* call XSAVES with an instruction mask of -1 and
> end up with a requested feature bitmap (RFBM) equal to XCR0, I think we
> can do a shortcut because we'll practically *always* have an
> xcomp_bv==RFBM==XCR0, which means that all (present) components will
> always have an address.

Actually, we depend on that anyway.  xstate_comp_offsets[] is completely
bogus if we don't have xcomp_bv==RFBM==XCR0.

Perhaps we need to add those checks anyway.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES Dave Hansen <dave.hansen@intel.com> - 2016-05-05 00:50 +0200

csiph-web