Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1394715
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [GIT PULL for v4.6-rc1] media updates |
| Date | 2016-05-04 23:00 +0200 |
| Message-ID | <rvc3M-2AW-9@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <ruQcX-7vl-27@gated-at.bofh.it> <ruQwi-7ET-9@gated-at.bofh.it> <ruWLn-5l2-3@gated-at.bofh.it> <rv9fA-85-23@gated-at.bofh.it> <rvaEJ-1v3-85@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, May 4, 2016 at 12:28 PM, Stefan Lippers-Hollmann <s.l-h@gmx.de> wrote:
>
> --- a/drivers/media/media-device.c
> +++ b/drivers/media/media-device.c
> @@ -875,7 +875,7 @@ void __media_device_usb_init(struct medi
> const char *board_name,
> const char *driver_name)
> {
> -#ifdef CONFIG_USB
> +#if defined(CONFIG_USB) || defined(CONFIG_USB_MODULE)
Ok, that should be fine. Can you verify that it builds and works even
if USB isn't compiled in, but the media core code is?
IOW, can you test the
CONFIG_USB=m
CONFIG_MEDIA_CONTROLLER=y
CONFIG_MEDIA_SUPPORT=y
case? Judging by your oops stack trace, I think you currently have
MEDIA_SUPPORT=m.
Also, I do wonder if we should move that #if to _outside_ the
function. Because inside the function, things will compile but
silently not work (like you found), if it is ever mis-used. Outside
that function, you'll get link-errors if you try to misuse that
function.
Linus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [GIT PULL for v4.6-rc1] media updates Stefan Lippers-Hollmann <s.l-h@gmx.de> - 2016-05-03 23:40 +0200
Re: [GIT PULL for v4.6-rc1] media updates Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-04 00:00 +0200
Re: [GIT PULL for v4.6-rc1] media updates Stefan Lippers-Hollmann <s.l-h@gmx.de> - 2016-05-04 06:40 +0200
Re: [GIT PULL for v4.6-rc1] media updates Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-04 20:00 +0200
Re: [GIT PULL for v4.6-rc1] media updates Stefan Lippers-Hollmann <s.l-h@gmx.de> - 2016-05-04 21:30 +0200
Re: [GIT PULL for v4.6-rc1] media updates Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-04 23:00 +0200
Re: [GIT PULL for v4.6-rc1] media updates Stefan Lippers-Hollmann <s.l-h@gmx.de> - 2016-05-04 23:50 +0200
Re: [GIT PULL for v4.6-rc1] media updates Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-05-05 00:00 +0200
Re: [GIT PULL for v4.6-rc1] media updates Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-05-05 13:10 +0200
Re: [GIT PULL for v4.6-rc1] media updates Stefan Lippers-Hollmann <s.l-h@gmx.de> - 2016-05-06 02:10 +0200
csiph-web