Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1396165

Re: [PATCH net-next 04/21] net: dsa: mv88e6xxx: factorize EEPROM access

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 04/21] net: dsa: mv88e6xxx: factorize EEPROM access
Date 2016-05-07 00:30 +0200
Message-ID <rvWpZ-5eP-35@gated-at.bofh.it> (permalink)
References <rvVWV-4tS-5@gated-at.bofh.it> <rvW6C-4ZK-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> @@ -2596,6 +2797,9 @@ int mv88e6xxx_setup_common(struct mv88e6xxx_priv_state *ps)
>  
>  	INIT_WORK(&ps->bridge_work, mv88e6xxx_bridge_work);
>  
> +	if (mv88e6xxx_has(ps, MV88E6XXX_FLAG_EEPROM))
> +		mutex_init(&ps->eeprom_mutex);
> +

This seems to be the only place MV88E6XXX_FLAG_EEPROM is checked.  It
seems like mv88e6xxx_get_eeprom() and and mv88e6xxx_set_eeprom()
should also check this.

       Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH net-next 04/21] net: dsa: mv88e6xxx: factorize EEPROM access Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-07 00:10 +0200
  Re: [PATCH net-next 04/21] net: dsa: mv88e6xxx: factorize EEPROM  access Andrew Lunn <andrew@lunn.ch> - 2016-05-07 00:30 +0200

csiph-web