Re: [PATCH] rpmsg: Make rpmsg sample selectable

From	Suman Anna <s-anna@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rpmsg: Make rpmsg sample selectable
Date	2016-05-06 21:30 +0200
Message-ID	<rvTBL-2AR-5@gated-at.bofh.it> (permalink)
References	<rvSmo-1A4-63@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Bjorn,

On 05/06/2016 01:06 PM, Bjorn Andersson wrote:
> rpmsg is not user selectable so the rpmsg sample should not depend on
> it, as this limits the possibility of compiling the sample client
> without any other clients.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  samples/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/samples/Kconfig b/samples/Kconfig
> index d54f28c6dc5e..61a251e579ed 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -57,7 +57,8 @@ config SAMPLE_KDB
>  
>  config SAMPLE_RPMSG_CLIENT
>  	tristate "Build rpmsg client sample -- loadable modules only"
> -	depends on RPMSG && m
> +	select RPMSG
> +	depends on m

Well, I believe this has to do with the fact that we also need to have a
remoteproc driver enabled, as you cannot have the sample running by
itself. A remoteproc driver implementing RPMSG would select it, and then
this sample can be enabled. In fact, I follow this for all rpmsg bus
drivers.

regards
Suman

>  	help
>  	  Build an rpmsg client sample driver, which demonstrates how
>  	  to communicate with an AMP-configured remote processor over
>

Thread

[PATCH] rpmsg: Make rpmsg sample selectable Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-06 20:10 +0200
  Re: [PATCH] rpmsg: Make rpmsg sample selectable Suman Anna <s-anna@ti.com> - 2016-05-06 21:30 +0200
    Re: [PATCH] rpmsg: Make rpmsg sample selectable Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-07 00:20 +0200
      Re: [PATCH] rpmsg: Make rpmsg sample selectable Suman Anna <s-anna@ti.com> - 2016-05-11 17:40 +0200
        Re: [PATCH] rpmsg: Make rpmsg sample selectable Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-05-11 21:50 +0200

csiph-web