Re: [PATCH 3/3] mm: thp: split_huge_pmd_address() comment improvement

From	"Kirill A. Shutemov" <kirill@shutemov.name>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] mm: thp: split_huge_pmd_address() comment improvement
Date	2016-05-06 19:40 +0200
Message-ID	<rvRTl-13G-7@gated-at.bofh.it> (permalink)
References	<rvPy9-7xW-1@gated-at.bofh.it> <rvPya-7xW-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 06, 2016 at 05:04:00PM +0200, Andrea Arcangeli wrote:
> Comment is partly wrong, this improves it by including the case of
> split_huge_pmd_address() called by try_to_unmap_one if
> TTU_SPLIT_HUGE_PMD is set.
> 
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

> ---
>  mm/huge_memory.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 9086793..1fbe13d 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -3031,8 +3031,10 @@ void split_huge_pmd_address(struct vm_area_struct *vma, unsigned long address,
>  		return;
>  
>  	/*
> -	 * Caller holds the mmap_sem write mode, so a huge pmd cannot
> -	 * materialize from under us.
> +	 * Caller holds the mmap_sem write mode or the anon_vma lock,
> +	 * so a huge pmd cannot materialize from under us (khugepaged
> +	 * holds both the mmap_sem write mode and the anon_vma lock
> +	 * write mode).
>  	 */
>  	__split_huge_pmd(vma, pmd, address, freeze);
>  }

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] mm: thp: mapcount updates Andrea Arcangeli <aarcange@redhat.com> - 2016-05-06 17:10 +0200
  [PATCH 2/3] mm: thp: microoptimize compound_mapcount() Andrea Arcangeli <aarcange@redhat.com> - 2016-05-06 17:10 +0200
    Re: [PATCH 2/3] mm: thp: microoptimize compound_mapcount() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-05-06 19:40 +0200
  [PATCH 1/3] mm: thp: calculate the mapcount correctly for THP pages during WP faults Andrea Arcangeli <aarcange@redhat.com> - 2016-05-06 17:10 +0200
    Re: [PATCH 1/3] mm: thp: calculate the mapcount correctly for THP  pages during WP faults Alex Williamson <alex.williamson@redhat.com> - 2016-05-07 00:20 +0200
    Re: [PATCH 1/3] mm: thp: calculate the mapcount correctly for THP  pages during WP faults Andrew Morton <akpm@linux-foundation.org> - 2016-05-10 00:30 +0200
    [PATCH 1/1] mm: thp: calculate the mapcount correctly for THP pages during WP faults Andrea Arcangeli <aarcange@redhat.com> - 2016-05-10 21:30 +0200
      Re: [1/1] mm: thp: calculate the mapcount correctly for THP pages during WP faults Mike Marciniszyn <mike.marciniszyn@intel.com> - 2016-05-11 23:30 +0200
  [PATCH 3/3] mm: thp: split_huge_pmd_address() comment improvement Andrea Arcangeli <aarcange@redhat.com> - 2016-05-06 17:10 +0200
    Re: [PATCH 3/3] mm: thp: split_huge_pmd_address() comment improvement "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-05-06 19:40 +0200

csiph-web