Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1395924

Re: [PATCH] of: fix device compatibility scoring

From Reza Arbab <arbab@linux.vnet.ibm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] of: fix device compatibility scoring
Date 2016-05-06 17:20 +0200
Message-ID <rvPHQ-7CY-13@gated-at.bofh.it> (permalink)
References <rvwlQ-5gq-19@gated-at.bofh.it> <rvxrz-6ic-9@gated-at.bofh.it>
Organization IBM Linux Technology Center

Show all headers | View raw


On Thu, May 05, 2016 at 02:47:18PM -0500, Rob Herring wrote:
>This matching is very sensitive to changes. Can you please describe
>what conditions don't work for you and add a test case for that
>condition to the unit test.

Ah, thanks for pointing out the unit test.

Looking at the test cases there cleared up the misunderstanding I had 
which led me to suggest the patch. It does seem that the 
short-circuiting in __of_device_is_compatible() is intentional.

Please disregard. Sorry for the noise.

-- 
Reza Arbab

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] of: fix device compatibility scoring Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-05-05 20:40 +0200
  Re: [PATCH] of: fix device compatibility scoring Rob Herring <robh+dt@kernel.org> - 2016-05-05 21:50 +0200
    Re: [PATCH] of: fix device compatibility scoring Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-05-06 17:20 +0200

csiph-web