Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1395869

Re: [PATCH v1 0/2] dmaengine: urgent fix to prevent regression in UART

Show all headers | View raw

+Cc: Heikki

On Wed, 2016-05-04 at 22:29 +0300, Andy Shevchenko wrote:
> There are two patches, first of which is an urgent fix to prevent a
> regression
> when UART driver can't acquire DMA channel due to DMA engine which
> doesn't
> support DMA_CYCLIC.

Have to add the following.

The commit ec5a11a91eec ("serial: 8250: Validate dmaengine rx chan meets
requirements") brought a check for DMA capabilities and UART will not
acquire a DMA channel if DMA engine doesn't support both DMA_CYCLIC
_and_ DMA_SLAVE. The first patch in the series changes the logic from
_and_ to _or_.

> 
> Andy Shevchenko (2):
>   dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC
>   dmaengine: rename cmd_pause to cmd_suspend
> 
>  drivers/dma/dmaengine.c               | 8 ++++----
>  drivers/tty/serial/8250/8250_dma.c    | 2 +-
>  include/linux/dmaengine.h             | 4 ++--
>  sound/soc/soc-generic-dmaengine-pcm.c | 2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/2] dmaengine: urgent fix to prevent regression in UART Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-04 21:40 +0200
  Re: [PATCH v1 0/2] dmaengine: urgent fix to prevent regression in  UART Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-06 15:40 +0200

csiph-web