RE: [PATCH] x86, tsc: Fix tsc ratio calibration to avoid broken mdelay

From	"Chen, Yu C" <yu.c.chen@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] x86, tsc: Fix tsc ratio calibration to avoid broken mdelay
Date	2016-05-06 14:50 +0200
Message-ID	<rvNmG-5ee-1@gated-at.bofh.it> (permalink)
References	<rvECK-5qY-7@gated-at.bofh.it> <rvKyt-2xM-5@gated-at.bofh.it> <rvKI9-2Dh-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> -----Original Message-----
> From: Thomas Gleixner [mailto:tglx@linutronix.de]
> Sent: Friday, May 06, 2016 5:53 PM
> To: Chen, Yu C
> Cc: x86@kernel.org; linux-kernel@vger.kernel.org; Ingo Molnar; H. Peter Anvin;
> Gao, Bin; Len Brown; Rafael J. Wysocki; 3 . 14+ # 3 . 14+
> Subject: Re: [PATCH] x86, tsc: Fix tsc ratio calibration to avoid broken mdelay
> 
> 
> On Fri, 6 May 2016, Thomas Gleixner wrote:
> > On Fri, 6 May 2016, yu.c.chen@intel.com wrote:
> > > From: Chen Yu <yu.c.chen@intel.com>
> > >
> > > Currently we fetch the tsc radio by:
> > > ratio = (lo >> 8) & 0x1f;
> > > thus get bit8~bit12 of the MSR_PLATFORM_INFO, however according to
> > > Intel 64 and IA-32 Architectures Software Developer Manual 35.5, the
> > > ratio bit should be bit8~bit15, otherwise we might get incorrect tsc
> > > ratio and cause system hang later(mdelay corrupted).
> >
> > The resulting issue is that both TSC frequency, which is used for
> > udelay, and the lapic timer frequency are wrong. mdelay is just the
> > visible damage caused by that.
> 
> Aside of that:
> 
> > Cc: 3.14+ <stable@vger.kernel.org> # 3.14+
> 
> Please use:
> 
> Fixes: commit '....'
> 
> next time, which identifies the kernel version to which this needs to be
> backported and gives a reference to the commit which caused the issue.
> 
OK, thanks!

Thread

[PATCH] x86, tsc: Fix tsc ratio calibration to avoid broken mdelay yu.c.chen@intel.com - 2016-05-06 05:30 +0200
  Re: [PATCH] x86, tsc: Fix tsc ratio calibration to avoid broken  mdelay Thomas Gleixner <tglx@linutronix.de> - 2016-05-06 11:50 +0200
    Re: [PATCH] x86, tsc: Fix tsc ratio calibration to avoid broken  mdelay Thomas Gleixner <tglx@linutronix.de> - 2016-05-06 12:00 +0200
      RE: [PATCH] x86, tsc: Fix tsc ratio calibration to avoid broken  mdelay "Chen, Yu C" <yu.c.chen@intel.com> - 2016-05-06 14:50 +0200
  [tip:x86/urgent] x86/tsc: Read all ratio bits from  MSR_PLATFORM_INFO tip-bot for Chen Yu <tipbot@zytor.com> - 2016-05-06 12:00 +0200

csiph-web