Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1395801

Re: cpufreq governors broken with !CONFIG_SMP?

From "Rafael J. Wysocki" <rafael@kernel.org>
Newsgroups linux.kernel
Subject Re: cpufreq governors broken with !CONFIG_SMP?
Date 2016-05-06 13:50 +0200
Message-ID <rvMqC-4be-11@gated-at.bofh.it> (permalink)
References <rvBbQ-1tA-15@gated-at.bofh.it> <rvBvb-20s-7@gated-at.bofh.it> <rvBOy-2eS-7@gated-at.bofh.it> <rvMqC-4be-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, May 6, 2016 at 1:46 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, May 06, 2016 at 02:25:16AM +0200, Rafael J. Wysocki wrote:
>> On Friday, May 06, 2016 02:09:07 AM Rafael J. Wysocki wrote:
>> > On Thursday, May 05, 2016 04:49:22 PM Steve Muckle wrote:
>> > > While working on a few patches for schedutil I noticed that the CFS
>> > > cpufreq hooks depend on PELT, which depends on CONFIG_SMP.
>
>> > For governors other than schedutil fixing that would be a matter of
>> > adding a !CONFIG_SMP variant of update_load_avg() that will call
>> > cpufreq_update_util() and do nothing else.  It doesn't matter what
>> > is passed via util and max then.
>>
>> Maybe something like the below, FWIW, as a quick fix for 4.6?
>
> Right; I suppose that'll have to do for 4.6.

OK, thanks!

I'll resend it with a changelog and stuff then.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

cpufreq governors broken with !CONFIG_SMP? Steve Muckle <steve.muckle@linaro.org> - 2016-05-06 01:50 +0200
  Re: cpufreq governors broken with !CONFIG_SMP? "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-06 02:10 +0200
    Re: cpufreq governors broken with !CONFIG_SMP? Steve Muckle <steve.muckle@linaro.org> - 2016-05-06 02:30 +0200
      Re: cpufreq governors broken with !CONFIG_SMP? "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-06 02:40 +0200
      Re: cpufreq governors broken with !CONFIG_SMP? Peter Zijlstra <peterz@infradead.org> - 2016-05-06 13:50 +0200
    Re: cpufreq governors broken with !CONFIG_SMP? "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-06 02:30 +0200
      Re: cpufreq governors broken with !CONFIG_SMP? "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-06 13:50 +0200
      Re: cpufreq governors broken with !CONFIG_SMP? Peter Zijlstra <peterz@infradead.org> - 2016-05-06 13:50 +0200

csiph-web