Re: [PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings"

From	"David.Wu" <david.wu@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings"
Date	2016-05-06 04:20 +0200
Message-ID	<rvDwZ-4hI-3@gated-at.bofh.it> (permalink)
References	<rv5OG-5wR-9@gated-at.bofh.it> <rv5OG-5wR-11@gated-at.bofh.it> <rvAps-Kj-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Doug,

在 2016/5/6 6:55, Doug Anderson 写道:
> David,
>
> On Wed, May 4, 2016 at 7:13 AM, David Wu <david.wu@rock-chips.com> wrote:
>> Signed-off-by: David Wu <david.wu@rock-chips.com>
>
> Usually folks like a description and not just a subject line.  I'd add
> a description like:
>
> The "div_high" and "div_low" values are always used together.  Group them
> into a structure to make it easier to pass them both around.  This
> structure also provides a place for future calculated timings.
>

Okay, i will add it in next version, thanks.

>> ---
>> Change in v7:
>> - none
>>
>>   drivers/i2c/busses/i2c-rk3x.c | 55 +++++++++++++++++++++++++------------------
>>   1 file changed, 32 insertions(+), 23 deletions(-)
>
> Other than the description, I think this looks fine.
>
> IMHO this can be applied any time independent of any earlier patches.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings" David Wu <david.wu@rock-chips.com> - 2016-05-04 16:20 +0200
  Re: [PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings" Doug Anderson <dianders@chromium.org> - 2016-05-06 01:00 +0200
    Re: [PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings" "David.Wu" <david.wu@rock-chips.com> - 2016-05-06 04:20 +0200

csiph-web