Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1395452
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU |
| Date | 2016-05-06 01:00 +0200 |
| Message-ID | <rvAps-Kj-13@gated-at.bofh.it> (permalink) |
| References | <rvAfL-Dg-3@gated-at.bofh.it> <rvAfM-Dg-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> -static int mv88e6xxx_ppu_access_get(struct mv88e6xxx_priv_state *ps)
> +static int _mv88e6xxx_ppu_access_get(struct mv88e6xxx_priv_state *ps)
Hi Vivien
We agreed to stop adding _ to functions that assume the lock has been
taken. Now that we check the lock is held in lowest level function, it
quickly becomes clear if the locks are wrong. It either deadlocks, or
it prints a warning when there is an error.
Please don't rename these functions.
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200 Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU Andrew Lunn <andrew@lunn.ch> - 2016-05-06 01:00 +0200 Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU Andrew Lunn <andrew@lunn.ch> - 2016-05-06 01:00 +0200 Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU Andrew Lunn <andrew@lunn.ch> - 2016-05-06 01:10 +0200
csiph-web