Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1395449

Re: [PATCH v7 5/9] i2c: rk3x: Change SoC data to not use array

Show all headers | View raw

Hi,

On Wed, May 4, 2016 at 7:33 AM, David Wu <david.wu@rock-chips.com> wrote:
> Signed-off-by: David Wu <david.wu@rock-chips.com>

nit: $SUBJECT should probably mention that this also constifies the SoC data.


Again, needs description, like maybe:

Specifying the i2c SoC data in an array provides very little benefit and
gets unwieldly / confusing as the array grows since the next bit of code
needs to refer to elements in the array by their raw integral index.

Let's just create a single 'static const' structure for each SoC so that
we can refer to these structures by ID.


IMHO this can be applied any time independent of any earlier patches.

Suggested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/9] add i2c driver supported for rk3399 David Wu <david.wu@rock-chips.com> - 2016-05-04 16:30 +0200
  [PATCH v7 6/9] i2c: rk3x: Move spec timing data to "static const" structs David Wu <david.wu@rock-chips.com> - 2016-05-04 16:40 +0200
    Re: [PATCH v7 6/9] i2c: rk3x: Move spec timing data to "static const" structs Doug Anderson <dianders@chromium.org> - 2016-05-06 01:00 +0200
      Re: [PATCH v7 6/9] i2c: rk3x: Move spec timing data to "static const"  structs "David.Wu" <david.wu@rock-chips.com> - 2016-05-06 07:00 +0200
  [PATCH v7 9/9] i2c: rk3x: support fast-mode plus for rk3399 David Wu <david.wu@rock-chips.com> - 2016-05-04 16:40 +0200
    Re: [PATCH v7 9/9] i2c: rk3x: support fast-mode plus for rk3399 Doug Anderson <dianders@chromium.org> - 2016-05-06 01:10 +0200
      Re: [PATCH v7 9/9] i2c: rk3x: support fast-mode plus for rk3399 "David.Wu" <david.wu@rock-chips.com> - 2016-05-06 04:20 +0200
  [PATCH v7 5/9] i2c: rk3x: Change SoC data to not use array David Wu <david.wu@rock-chips.com> - 2016-05-04 16:40 +0200
    Re: [PATCH v7 5/9] i2c: rk3x: Change SoC data to not use array Heiko Stübner <heiko@sntech.de> - 2016-05-05 23:40 +0200
    Re: [PATCH v7 5/9] i2c: rk3x: Change SoC data to not use array Doug Anderson <dianders@chromium.org> - 2016-05-06 01:00 +0200
  [PATCH v7 8/9] i2c: rk3x: add i2c support for rk3399 soc David Wu <david.wu@rock-chips.com> - 2016-05-04 16:40 +0200
    Re: [PATCH v7 8/9] i2c: rk3x: add i2c support for rk3399 soc Doug Anderson <dianders@chromium.org> - 2016-05-06 01:10 +0200
      Re: [PATCH v7 8/9] i2c: rk3x: add i2c support for rk3399 soc "David.Wu" <david.wu@rock-chips.com> - 2016-05-06 11:40 +0200
        Re: [PATCH v7 8/9] i2c: rk3x: add i2c support for rk3399 soc Doug Anderson <dianders@chromium.org> - 2016-05-06 20:10 +0200
  [PATCH v7 7/9] dt-bindings: i2c: rk3x: add support for rk3399 David Wu <david.wu@rock-chips.com> - 2016-05-04 16:40 +0200
    Re: [PATCH v7 7/9] dt-bindings: i2c: rk3x: add support for rk3399 Rob Herring <robh@kernel.org> - 2016-05-06 00:20 +0200
      Re: [PATCH v7 7/9] dt-bindings: i2c: rk3x: add support for rk3399 "David.Wu" <david.wu@rock-chips.com> - 2016-05-06 08:10 +0200
    Re: [PATCH v7 7/9] dt-bindings: i2c: rk3x: add support for rk3399 Doug Anderson <dianders@chromium.org> - 2016-05-06 01:10 +0200

csiph-web