Re: [PATCH] drm/sun4i: add COMMON_CLK dependency

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/sun4i: add COMMON_CLK dependency
Date	Wed, 04 May 2016 20:40:02 +0200
Message-ID	<rv9Si-Pg-31@gated-at.bofh.it> (permalink)
References	<rujTI-2ar-1@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DGEpNJVZyRrKVy7j"
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	63
Organization	linux.* mail to news gateway
X-Original-Cc	David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>, Dave Airlie <airlied@redhat.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 4 May 2016 20:33:47 +0200
X-Original-Message-ID	<20160504183347.GE17159@lukather>
X-Original-References	<1462186805-2211918-1-git-send-email-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1394614

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Mon, May 02, 2016 at 12:59:48PM +0200, Arnd Bergmann wrote:
> The sun4i drm driver uses the clk-provider interfaces, which are not available
> when CONFIG_COMMON_CLK is disabled:
> 
> drivers/gpu/drm/sun4i/sun4i_dotclock.c:19:16: error: field 'hw' has incomplete type
>   struct clk_hw hw;
> In file included from ../include/asm-generic/bug.h:13:0,
>                  from ../arch/arm/include/asm/bug.h:59,
>                  from ../include/linux/bug.h:4,
>                  from ../include/linux/io.h:23,
>                  from ../include/linux/clk-provider.h:14,
>                  from ../drivers/gpu/drm/sun4i/sun4i_dotclock.c:13:
> drivers/gpu/drm/sun4i/sun4i_dotclock.c: In function 'hw_to_dclk':
> include/linux/kernel.h:831:48: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> ...
> 
> This adds a Kconfig dependency to prevent the driver from being enabled
> in this case.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/sun4i: add COMMON_CLK dependency Arnd Bergmann <arnd@arndb.de> - 2016-05-02 13:10 +0200
  Re: [PATCH] drm/sun4i: add COMMON_CLK dependency Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-04 20:40 +0200

csiph-web