Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1394419

Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset

Show all headers | View raw

On Wed, May 04, 2016 at 04:39:59PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> There are three EHCI controllers on Tegra SoCs, each with its own reset
> line. However, the first controller contains a set of UTMI configuration
> registers that are shared with its siblings. These registers will only
> be reset as part of the first controller's reset. For proper operation
> it must be ensured that the UTMI configuration registers are reset
> before any of the EHCI controllers are enabled, irrespective of the
> probe order.
> 
> Commit a47cc24cd1e5 ("USB: EHCI: tegra: Fix probe order issue leading to
> broken USB") introduced code that ensures the first controller is always
> reset before setting up any of the controllers, and is never again reset
> afterwards.
> 
> This code, however, grabs the wrong reset. Each EHCI controller has two
> reset controls attached: 1) the USB controller reset and 2) the UTMI
> pads reset (really the first controller's reset). In order to reset the
> UTMI pads registers the code must grab the second reset, but instead it
> grabbing the first.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Any reason you don't want this backported to stable kernels?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset Thierry Reding <thierry.reding@gmail.com> - 2016-05-04 16:50 +0200
  Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads  reset Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-04 17:00 +0200
    Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads  reset Thierry Reding <thierry.reding@gmail.com> - 2016-05-04 17:30 +0200
      Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads  reset Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> - 2016-05-05 18:10 +0200
  Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads  reset Stephen Warren <swarren@wwwdotorg.org> - 2016-05-04 19:20 +0200
    Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads  reset Thierry Reding <thierry.reding@gmail.com> - 2016-05-04 22:40 +0200
  Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads  reset Jon Hunter <jonathanh@nvidia.com> - 2016-05-05 09:40 +0200

csiph-web