Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1394316
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Input: add Atmel Atmegaxx captouch driver |
| Date | 2016-05-04 16:00 +0200 |
| Message-ID | <rv5vk-4VB-25@gated-at.bofh.it> (permalink) |
| References | <ruM9k-3Bx-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 03, 2016 at 10:13:31AM -0700, Grant Grundler wrote:
> Add I2C driver for AtmegaXX capacitive touch device.
>
> Signed-off-by: Hung-yu Wu <hywu@google.com>
> Signed-off-by: Grant Grundler <grundler@chromium.org>
> ---
> .../bindings/input/atmel,atmegaxx_captouch.txt | 34 +++
It is generally preferred that bindings are a separate patch.
> drivers/input/misc/Kconfig | 11 +
> drivers/input/misc/Makefile | 1 +
> drivers/input/misc/atmegaxx_captouch.c | 278 +++++++++++++++++++++
> 4 files changed, 324 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/atmel,atmegaxx_captouch.txt
> create mode 100644 drivers/input/misc/atmegaxx_captouch.c
>
> For those that like to know how sausage is made, ChromeOS code review history here:
> https://chromium-review.googlesource.com/339950
>
> Driver was tested with prototype HW and it reliably reports events correctly.
> Manual testing was just using "evtest /dev/input/event0" and watch for events.
>
> diff --git a/Documentation/devicetree/bindings/input/atmel,atmegaxx_captouch.txt b/Documentation/devicetree/bindings/input/atmel,atmegaxx_captouch.txt
> new file mode 100644
> index 0000000..07a4b0b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/atmel,atmegaxx_captouch.txt
> @@ -0,0 +1,34 @@
> +Device tree bindings for Atmel AtmegaXX capacitive touch sensor
> +
> +The node for this device must be a child of a I2C controller node, as the
> +device communicates via I2C.
> +
> +Required properties:
> +
> + compatible: Must be "atmel,atmegaxx_captouch".
No wildcards in the compatible strings. Use the specific devices.
Also, use hyphen rather than underscore. However, if the device is only
a touch controller, then '_captouch' is not needed. The part number is
sufficient to identify the device.
> + reg: The I2C slave address of the device.
> + interrupts: Property describing the interrupt line the device
> + is connected to. The device only has one interrupt
> + source.
> + linux,keycodes: Specifies an array of numeric keycode values to
> + be used for reporting button presses. The array can
> + contain up to 8 entries.
> +
> +Optional properties:
> +
> + autorepeat: Enables the Linux input system's autorepeat
> + feature on the input device.
> +
> +Example:
> +
> + atmegaxx_captouch@51 {
atmegaxx@51 (with actual part number)
> + compatible = "atmel,atmegaxx_captouch";
> + reg = <0x51>;
> + interrupt-parent = <&tlmm>;
> + interrupts = <67 IRQ_TYPE_EDGE_FALLING>;
> + linux,keycodes = <BTN_0>, <BTN_1>,
> + <BTN_2>, <BTN_3>,
> + <BTN_4>, <BTN_5>,
> + <BTN_6>, <BTN_7>;
> + autorepeat;
> + };
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Input: add Atmel Atmegaxx captouch driver Grant Grundler <grundler@chromium.org> - 2016-05-03 19:20 +0200
Re: Input: add Atmel Atmegaxx captouch driver Rob Herring <robh@kernel.org> - 2016-05-04 16:00 +0200
Re: Input: add Atmel Atmegaxx captouch driver Grant Grundler <grundler@chromium.org> - 2016-05-04 18:50 +0200
Re: Input: add Atmel Atmegaxx captouch driver Grant Grundler <grundler@chromium.org> - 2016-05-05 18:10 +0200
Re: Input: add Atmel Atmegaxx captouch driver Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-05-06 11:30 +0200
Re: Input: add Atmel Atmegaxx captouch driver Grant Grundler <grundler@chromium.org> - 2016-05-06 20:30 +0200
Re: Input: add Atmel Atmegaxx captouch driver Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-09 18:40 +0200
Re: Input: add Atmel Atmegaxx captouch driver Grant Grundler <grundler@chromium.org> - 2016-05-09 18:50 +0200
csiph-web