Re: [PATCH] perf/core / arm_pmu: special-case hetereogeneous CPUs

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf/core / arm_pmu: special-case hetereogeneous CPUs
Date	2016-05-04 15:50 +0200
Message-ID	<rv5lF-4Ot-31@gated-at.bofh.it> (permalink)
References	<rrSXF-1rj-39@gated-at.bofh.it> <rrU3n-2yD-11@gated-at.bofh.it> <rs8zo-652-11@gated-at.bofh.it> <rv5lE-4Ot-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 04, 2016 at 02:44:20PM +0100, Mark Rutland wrote:
> Hi,
> 
> On Tue, Apr 26, 2016 at 11:33:46AM +0100, Mark Rutland wrote:
> > On Mon, Apr 25, 2016 at 09:03:34PM +0200, Peter Zijlstra wrote:
> > > On Mon, Apr 25, 2016 at 06:58:37PM +0100, Mark Rutland wrote:
> > > > Hi,
> > > > 
> > > > When booting an arm64 defconfig linux-next (next-20160422) on an ARM
> > > > Juno system, I hit a WARN_ON_ONCE in perf_pmu_register (see backtrace at
> > > > the end of this email).
> > > > 
> > > > This was introduced by commit 26657848502b7847 ("perf/core: Verify we
> > > > have a single perf_hw_context PMU") where we forcefully prevent multiple
> > > > PMUs from sharing perf_hw_context (with a warning), and force additional
> > > > PMUs to use perf_invalid_context.
> > 
> > > > Are you happy to revert 26657848502b787 for the timebeing? Or to somehow
> > > > predicate the check such that it doesn't adversely affect those HW PMUs?
> > > 
> > > I'm happy with a chicken bit for now, its already found two real issues,
> > > so I'd like to keep it.
> > 
> > Ok, how about the below? (based on next-20160422).
> 
> Peter, any thoughts?
> 
> This is still an issue for us in next-20160504 (to which the patch still
> applies).
> 
> Will, I assume that you're ok with the change to drivers/perf/arm_pmu.c.

Yes, they're pretty straighforward.

Will

Thread

Re: [PATCH] perf/core / arm_pmu: special-case hetereogeneous CPUs Mark Rutland <mark.rutland@arm.com> - 2016-05-04 15:50 +0200
  Re: [PATCH] perf/core / arm_pmu: special-case hetereogeneous CPUs Will Deacon <will.deacon@arm.com> - 2016-05-04 15:50 +0200
  Re: [PATCH] perf/core / arm_pmu: special-case hetereogeneous CPUs Peter Zijlstra <peterz@infradead.org> - 2016-05-04 17:10 +0200
    Re: [PATCH] perf/core / arm_pmu: special-case hetereogeneous CPUs Mark Rutland <mark.rutland@arm.com> - 2016-05-04 17:30 +0200

csiph-web