Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1394256
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 1/3] ARM: dts: exynos: Define vqmmc for SD card and allow disabling regulators on Odroid X/X2/U3 |
| Date | 2016-05-04 14:50 +0200 |
| Message-ID | <rv4pA-3RN-15@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The SD-card vmmc-supply contained incorrectly two regulators. The second one is ignored. Fix this by defining proper vmmc and vqmmc supplies. Additionally these regulators do not have to be always on, so allow disabling them to reduce energy consumption. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes since v2: 1. Add Javier's tag. Changes since v1: 1. None --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index cab0f07d7d28..3d0d44581fbd 100644 --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi @@ -249,7 +249,6 @@ regulator-name = "VDDQ_MMC2_2.8V"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; - regulator-always-on; regulator-boot-on; }; @@ -345,7 +344,6 @@ regulator-name = "LDO21_3.3V"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; - regulator-always-on; regulator-boot-on; }; @@ -482,7 +480,8 @@ bus-width = <4>; pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>; pinctrl-names = "default"; - vmmc-supply = <&ldo4_reg &ldo21_reg>; + vmmc-supply = <&ldo21_reg>; + vqmmc-supply = <&ldo4_reg>; cd-gpios = <&gpk2 2 GPIO_ACTIVE_HIGH>; cd-inverted; status = "okay"; -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH v3 1/3] ARM: dts: exynos: Define vqmmc for SD card and allow disabling regulators on Odroid X/X2/U3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-04 14:50 +0200
[PATCH v3 3/3] ARM: dts: exynos: Lower SD card interface voltage to 2.8 V on Odroid X/X2/U3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-04 14:50 +0200
Re: [PATCH v3 3/3] ARM: dts: exynos: Lower SD card interface voltage to 2.8 V on Odroid X/X2/U3 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-04 15:00 +0200
Re: [PATCH v3 3/3] ARM: dts: exynos: Lower SD card interface voltage to 2.8 V on Odroid X/X2/U3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-04 15:10 +0200
[PATCH v3 2/3] ARM: dts: exynos: Define vqmmc for eMMC card on Odroid X/X2/U3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-04 14:50 +0200
csiph-web