Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1394196

Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP

Show all headers | View raw

2016-05-04 19:44 GMT+08:00 Rafael J. Wysocki <rafael@kernel.org>:
> On Wed, May 4, 2016 at 2:58 AM, Wanpeng Li <kernellwp@gmail.com> wrote:
>> 2016-05-03 20:15 GMT+08:00 Rafael J. Wysocki <rafael@kernel.org>:
>>> On Tue, May 3, 2016 at 10:32 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>>>> On Tue, May 03, 2016 at 09:10:51AM +0800, kernel test robot wrote:
>>>>> FYI, we noticed the following commit:
>>>>>
>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
>>>>> commit 41e0d37f7ac81297c07ba311e4ad39465b8c8295 ("sched/fair: Do not call cpufreq hook unless util changed")
>>>>
>
> [cut]
>
>>>>
>>>> That's intel_pstate.c:get_avg_frequency(), which assumes mperf != 0. It
>>>> being 0 seems to suggest intel_pstate_sample() hasn't been called yet or
>>>> so.
>>>
>>> Well, what's the tree based on?
>>>
>>> The mainline does this:
>>>
>>> bool sample_taken = intel_pstate_sample(cpu, time);
>>>
>>> if (sample_taken && !hwp_active)
>>>         intel_pstate_adjust_busy_pstate(cpu);
>>>
>>> and (the mainline version of) intel_pstate_sample() returns false when
>>> it is called for the first time after setting the update_util hook.
>>
>> The callsites in scheduler will set time to rq_clock(rq) when trigger
>> sample, so when time 0 will be used even if it is set just before
>> setting the update_util hook?
>
> I'm not sure what you mean.
>
> time=0 is special as it will cause intel_pstate_sample() to return
> false on the next invocation.

Sample is driven by cpufreq_update_util() which uses rq_clock(rq) as
time parameter, so there is no opportunity to pass time 0 to
intel_pstate_sample().

Regards,
Wanpeng Li

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP Peter Zijlstra <peterz@infradead.org> - 2016-05-03 10:40 +0200
  Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP Wanpeng Li <kernellwp@gmail.com> - 2016-05-03 11:20 +0200
    Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP Wanpeng Li <kernellwp@gmail.com> - 2016-05-03 11:30 +0200
      Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-03 15:40 +0200
        Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP Wanpeng Li <kernellwp@gmail.com> - 2016-05-04 03:00 +0200
          Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP Wanpeng Li <kernellwp@gmail.com> - 2016-05-04 13:50 +0200
          Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-04 13:50 +0200
  Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-03 14:20 +0200
    Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-03 15:00 +0200
      Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-03 15:00 +0200
        Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-03 15:30 +0200
          Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-03 16:00 +0200
            Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-03 17:10 +0200
              Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP Wanpeng Li <kernellwp@gmail.com> - 2016-05-05 07:10 +0200
                Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-05 15:50 +0200
                Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP Wanpeng Li <kernellwp@gmail.com> - 2016-05-06 09:10 +0200
                Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-06 14:30 +0200
    Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP Wanpeng Li <kernellwp@gmail.com> - 2016-05-04 03:00 +0200
      Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-04 13:50 +0200
        Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP Wanpeng Li <kernellwp@gmail.com> - 2016-05-04 14:00 +0200
          Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-04 14:00 +0200
            Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP Wanpeng Li <kernellwp@gmail.com> - 2016-05-04 14:10 +0200
  [PATCH] intel_pstate: Fix intel_pstate_get() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-04 14:00 +0200

csiph-web