Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1394184
| From | Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] spi: zynqmp: disable clocks in error paths |
| Date | 2016-05-04 14:00 +0200 |
| Message-ID | <rv3Dc-38F-5@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The if pclk enable fails the refclk is not disabled. Fix the same. Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com> --- drivers/spi/spi-zynqmp-gqspi.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c index aab9b49..18aeace 100644 --- a/drivers/spi/spi-zynqmp-gqspi.c +++ b/drivers/spi/spi-zynqmp-gqspi.c @@ -360,7 +360,7 @@ static int zynqmp_prepare_transfer_hardware(struct spi_master *master) ret = clk_enable(xqspi->refclk); if (ret) - goto clk_err; + return ret; ret = clk_enable(xqspi->pclk); if (ret) @@ -369,6 +369,7 @@ static int zynqmp_prepare_transfer_hardware(struct spi_master *master) zynqmp_gqspi_write(xqspi, GQSPI_EN_OFST, GQSPI_EN_MASK); return 0; clk_err: + clk_disable(xqspi->refclk); return ret; } -- 1.7.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] spi: zynqmp: disable clocks in error paths Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> - 2016-05-04 14:00 +0200 Applied "spi: zynqmp: disable clocks in error paths" to the spi tree Mark Brown <broonie@kernel.org> - 2016-05-04 16:00 +0200
csiph-web