Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1394133

Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check

From Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check
Date 2016-05-04 12:30 +0200
Message-ID <rv2e6-23w-7@gated-at.bofh.it> (permalink)
References <ruOkN-5Mr-11@gated-at.bofh.it> <ruOkO-5Mr-21@gated-at.bofh.it> <ruYDv-77h-1@gated-at.bofh.it> <rv1i3-1hC-19@gated-at.bofh.it> <rv2e6-23w-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 04 May, at 12:23:40PM, Ingo Molnar wrote:
> 
> * Matt Fleming <matt@codeblueprint.co.uk> wrote:
> 
> > On Wed, 04 May, at 08:35:24AM, Ingo Molnar wrote:
> > > 
> > > * Matt Fleming <matt@codeblueprint.co.uk> wrote:
> > > 
> > > > From: Wang YanQing <udknight@gmail.com>
> > > > 
> > > > We can't just break out when meet start is equal to zero,
> > > 
> > > Hm, wot?
> > 
> > The existing code treats address 0x0 as invalid for a PCI BAR range
> > start address, but 0x0 is actually possible and legitimate, so we
> > shouldn't be breaking out of the loop.
> 
> Yeah, so I just don't understand the 'when meet start is equal to zero' part - 
> what does it mean?

I suspect it means "when start is equal to zero" or "when we encounter
the scenario where start is equal to zero".

Wang?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check Matt Fleming <matt@codeblueprint.co.uk> - 2016-05-03 21:40 +0200
  Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check Ingo Molnar <mingo@kernel.org> - 2016-05-04 08:40 +0200
    Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check Matt Fleming <matt@codeblueprint.co.uk> - 2016-05-04 11:30 +0200
      Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check Ingo Molnar <mingo@kernel.org> - 2016-05-04 12:30 +0200
        Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check Matt Fleming <matt@codeblueprint.co.uk> - 2016-05-04 12:30 +0200
    Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check Wang YanQing <udknight@gmail.com> - 2016-05-04 17:50 +0200

csiph-web