Re: [PATCH] rtc: rv3029: hide unused i2c device table

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: rv3029: hide unused i2c device table
Date	2016-05-04 12:10 +0200
Message-ID	<rv1UK-1RQ-7@gated-at.bofh.it> (permalink)
References	<rv1L5-1t3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/05/2016 at 11:50:02 +0200, Arnd Bergmann wrote :
> The added support for SPI mode made it possible to configure the driver
> when I2C is disabled, leaving an unused device table:
> 
> drivers/rtc/rtc-rv3029c2.c:794:29: error: 'rv3029_id' defined but not used [-Werror=unused-variable]
> 
> This moves the table inside of the #ifdef section that has the
> only user, to avoid the harmless warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: d08f50dd0afc ("rtc: rv3029: Add support of RV3049")
> ---
>  drivers/rtc/rtc-rv3029c2.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: rv3029: hide unused i2c device table Arnd Bergmann <arnd@arndb.de> - 2016-05-04 12:00 +0200
  Re: [PATCH] rtc: rv3029: hide unused i2c device table Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-05-04 12:10 +0200

csiph-web