Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1393025

Re: [PATCH v3 12/16] rtc: powerpc: provide rtc_class_ops directly

From Michael Ellerman <mpe@ellerman.id.au>
Newsgroups linux.kernel
Subject Re: [PATCH v3 12/16] rtc: powerpc: provide rtc_class_ops directly
Date 2016-05-03 06:10 +0200
Message-ID <ruzOO-PC-15@gated-at.bofh.it> (permalink)
References <rsGhH-P8-3@gated-at.bofh.it> <rsGhK-P8-67@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 2016-04-28 at 00:34 +0200, Arnd Bergmann wrote:

> The rtc-generic driver provides an architecture specific
> wrapper on top of the generic rtc_class_ops abstraction,
> and powerpc has another abstraction on top, which is a bit
> silly.
> 
> This changes the powerpc rtc-generic device to provide its
> rtc_class_ops directly, to reduce the number of layers
> by one.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/powerpc/kernel/time.c | 29 ++++++++++++++++++++++++++++-
>  drivers/rtc/rtc-generic.c  |  2 +-
>  2 files changed, 29 insertions(+), 2 deletions(-)

If this hits linux-next it will go through my automated boot testing, which
hopefully would be sufficient to catch any bugs in this patch, cross fingers.

I don't know jack about all the layers of RTC mess, so my ack is basically
worthless here. But if you like you can have one anyway :)

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH v3 12/16] rtc: powerpc: provide rtc_class_ops directly Michael Ellerman <mpe@ellerman.id.au> - 2016-05-03 06:10 +0200
  Re: [PATCH v3 12/16] rtc: powerpc: provide rtc_class_ops directly Arnd Bergmann <arnd@arndb.de> - 2016-05-03 12:40 +0200

csiph-web