Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1392478

Re: [PATCH v2 0/3] Add alignment check for DAX mount

Show all headers | View raw

On 05/02/2016 09:42 PM, Toshi Kani wrote:
> When a partition is not aligned by 4KB, mount -o dax succeeds,
> but any read/write access to the filesystem fails, except for
> metadata update.
> 
> Add alignment check to ext4, ext2, and xfs.
> 
> v2:
>  - Use a helper function via ->direct_access for the check.
>    (Christoph Hellwig)
>  - Call bdev_direct_access() with sector 0 for the check.
>    (Boaz Harrosh)
> 
> ---
> Toshi Kani (3):
>  1/3 ext4: Add alignment check for DAX mount
>  2/3 ext2: Add alignment check for DAX mount
>  3/3 xfs: Add alignment check for DAX mount
> 

All patches look very good to me, and keep the
internals internal. Thanks Toshi

Review-by: Boaz Harrosh <boaz@plexistor.com>

> ---
>  fs/ext2/super.c    | 21 +++++++++++++++++++--
>  fs/ext4/super.c    | 20 ++++++++++++++++++--
>  fs/xfs/xfs_super.c | 23 +++++++++++++++++++----
>  3 files changed, 56 insertions(+), 8 deletions(-)
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-05-02 21:00 +0200
  [PATCH v2 1/3] ext4: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-05-02 21:00 +0200
    Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount Jan Kara <jack@suse.cz> - 2016-05-03 10:00 +0200
    Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount Christoph Hellwig <hch@infradead.org> - 2016-05-03 10:50 +0200
      Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount Jan Kara <jack@suse.cz> - 2016-05-03 11:10 +0200
        Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-05-03 16:50 +0200
          Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-05-03 18:00 +0200
            Re: [PATCH v2 1/3] ext4: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-05-04 18:00 +0200
  [PATCH v2 3/3] xfs: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-05-02 21:00 +0200
    Re: [PATCH v2 3/3] xfs: Add alignment check for DAX mount Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-05-02 22:00 +0200
      Re: [PATCH v2 3/3] xfs: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-05-02 22:10 +0200
    Re: [PATCH v2 3/3] xfs: Add alignment check for DAX mount Dave Chinner <david@fromorbit.com> - 2016-05-05 01:20 +0200
      Re: [PATCH v2 3/3] xfs: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-05-05 02:00 +0200
        Re: [PATCH v2 3/3] xfs: Add alignment check for DAX mount Jan Kara <jack@suse.cz> - 2016-05-05 10:10 +0200
  Re: [PATCH v2 0/3] Add alignment check for DAX mount Boaz Harrosh <boaz@plexistor.com> - 2016-05-02 21:30 +0200

csiph-web