Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1392363

Re: [PATCH 1/2] kernfs_path_from_node_locked: don't overwrite nlen

Show all headers | View raw

On Wed, Apr 20, 2016 at 03:43:13PM -0400, Tejun Heo wrote:
> On Sun, Apr 17, 2016 at 03:04:31PM -0500, serge.hallyn@ubuntu.com wrote:
> > From: Serge Hallyn <serge.hallyn@ubuntu.com>
> > 
> > We've calculated @len to be the bytes we need for '/..' entries from
> > @kn_from to the common ancestor, and calculated @nlen to be the extra
> > bytes we need to get from the common ancestor to @kn_to.  We use them
> > as such at the end.  But in the loop copying the actual entries, we
> > overwrite @nlen.  Use a temporary variable for that instead.
> > 
> > Without this, the return length, when the buffer is large enough, is
> > wrong.  (When the buffer is NULL or too small, the returned value is
> > correct. The buffer contents are also correct.)
> > 
> > Interestingly, no callers of this function are affected by this as of
> > yet.  However the upcoming cgroup_show_path() will be.
> > 
> > Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
> 
> Acked-by: Tejun Heo <tj@kernel.org>
> 
> Greg, can you please pick this one up for v4.6?

Looks like Greg missed this one.  Greg, I'll route this through
cgroup/for-4.6-fixes.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] kernfs_path_from_node_locked: don't overwrite nlen Tejun Heo <tj@kernel.org> - 2016-05-02 18:40 +0200
  Re: [PATCH 1/2] kernfs_path_from_node_locked: don't overwrite nlen Greg KH <gregkh@linuxfoundation.org> - 2016-05-02 18:50 +0200

csiph-web