Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines

From	Christoph Hellwig <hch@lst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines
Date	2016-05-02 16:50 +0200
Message-ID	<runkD-58W-29@gated-at.bofh.it> (permalink)
References	<ronnj-3Vn-3@gated-at.bofh.it> <ronnk-3Vn-11@gated-at.bofh.it> <rtnZo-4me-7@gated-at.bofh.it> <ru3YC-5uY-15@gated-at.bofh.it> <rulVw-3Ub-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 02, 2016 at 08:11:24AM -0500, Bjorn Helgaas wrote:
> On Sun, May 01, 2016 at 08:01:49PM +0200, Christoph Hellwig wrote:
> > FYI, I spent some time trying to convert more drivers to this, and
> > I think we'll need an additional flag to skip MSI or MSI-X as there
> > is plenty of hardware claiming support in the capabilities flag,
> > but not actually supporting one of them.
> 
> Or maybe add a "pdev->msix_broken" bit and quirks to set it?  Or if
> pci_fixup_final quirks merely cleared pdev->msix_cap, I think the PCI
> core would never try to enable MSI-X.

Can't say I'm excited about quirks - now we'd have to patch core
code for something that previously was entirely in the driver.

Thread

Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines Bjorn Helgaas <helgaas@kernel.org> - 2016-04-29 23:20 +0200
  Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free  routines Christoph Hellwig <hch@lst.de> - 2016-05-01 20:10 +0200
    Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines Bjorn Helgaas <helgaas@kernel.org> - 2016-05-02 15:20 +0200
      Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free  routines Christoph Hellwig <hch@lst.de> - 2016-05-02 16:50 +0200
        Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines Bjorn Helgaas <helgaas@kernel.org> - 2016-05-02 17:30 +0200
          Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free  routines Christoph Hellwig <hch@lst.de> - 2016-05-03 23:20 +0200
            Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines Bjorn Helgaas <helgaas@kernel.org> - 2016-05-03 23:40 +0200

csiph-web