Re: [PATCH RESEND 12/12] of: Add sh support

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND 12/12] of: Add sh support
Date	2016-05-02 14:40 +0200
Message-ID	<ruliO-3kM-9@gated-at.bofh.it> (permalink)
References	<rtRNL-3JV-5@gated-at.bofh.it> <rtRXr-3NJ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, May 1, 2016 at 12:08 AM, Yoshinori Sato
<ysato@users.sourceforge.jp> wrote:
> sh fdt access in VA. But memory reservation use PA.
> So sh need convert to PA.
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
>  drivers/of/fdt.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 3349d2a..fb357be 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -593,6 +593,9 @@ void __init early_init_fdt_scan_reserved_mem(void)
>                 fdt_get_mem_rsv(initial_boot_params, n, &base, &size);
>                 if (!size)
>                         break;
> +#ifdef CONFIG_SUPERH
> +               base = virt_to_phys(base);
> +#endif
>                 early_init_dt_reserve_memory_arch(base, size, 0);

This is not right. base is already a physical address and
early_init_dt_reserve_memory_arch takes a physical address. The
default implementation using memblock also works on physical
addresses. It is a weak function so you can override it if you need to
do something special. But it seems something else is wrong here if you
need this.

Rob

Thread

[PATCH RESEND 00/12] SH: landisk convert to devicetree Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:10 +0200
  [PATCH RESEND 02/12] sh: Config update for OF mode Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:10 +0200
  [PATCH RESEND 07/12] pci: sh: SH7751 PCI host bridge driver Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:10 +0200
    Re: [PATCH RESEND 07/12] pci: sh: SH7751 PCI host bridge driver Bjorn Helgaas <helgaas@kernel.org> - 2016-05-02 18:50 +0200
    Re: [PATCH RESEND 07/12] pci: sh: SH7751 PCI host bridge driver Bjorn Helgaas <helgaas@kernel.org> - 2016-05-02 21:40 +0200
  [PATCH RESEND 08/12] intc: sh: Renesas Super H INTC driver Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:10 +0200
  [PATCH RESEND 12/12] of: Add sh support Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:20 +0200
    Re: [PATCH RESEND 12/12] of: Add sh support Rob Herring <robh@kernel.org> - 2016-05-02 14:40 +0200
      Re: [PATCH RESEND 12/12] of: Add sh support Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-10 09:50 +0200
  [PATCH RESEND 09/12] sh: Add I/O DATA HDL-U support drivers. Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:20 +0200
  [PATCH RESEND 01/12] sh: Fix typo Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:20 +0200
  [PATCH RESEND 11/12] sh: I/O DATA HDL-U defconfig (DT mode) Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:20 +0200
  [PATCH RESEND 03/12] sh: Disable board specific code in OF mode Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:20 +0200
    Re: [PATCH RESEND 03/12] sh: Disable board specific code in OF mode Rich Felker <dalias@libc.org> - 2016-05-04 05:00 +0200
      Re: [PATCH RESEND 03/12] sh: Disable board specific code in OF mode Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-10 09:30 +0200
  [PATCH RESEND 10/12] sh: I/O DATA HDL-U (aka landisk) support dts Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:20 +0200
    Re: [PATCH RESEND 10/12] sh: I/O DATA HDL-U (aka landisk) support dts Rich Felker <dalias@libc.org> - 2016-05-04 05:30 +0200
      Re: [PATCH RESEND 10/12] sh: I/O DATA HDL-U (aka landisk) support dts Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-10 09:50 +0200
  [PATCH RESEND 04/12] sh: Drop CPU specific setup on OF mode Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-05-01 07:20 +0200

csiph-web