Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1392126
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arnd Bergmann <arnd@arndb.de> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] drm/sun4i: add COMMON_CLK dependency |
| Date | Mon, 02 May 2016 13:10:02 +0200 |
| Message-ID | <rujTI-2ar-1@gated-at.bofh.it> (permalink) |
| X-Mailer | git-send-email 2.7.0 |
| X-Provags-ID | V03:K0:9hqo8puWvIpPyc5lcNBfwiIcogh7ZGEQZbLQ8ZE0rx1aDeyJAeX aKDzdOL4+I5Avya7GMKNNYf8eZE6BopFR8kyZGvBhTMVySsjoLBt1m++dHGsK7cb1FTk/Q0 F38z1B+OxXTMYFQXw3on0RpEG7M/gTbekTvWFDXX96HsdO2tXEtsNUVCUzbylUEKbv5TNtv JzPHujQT6ktsjMTrmMIWg== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:bWx/s7FDWOE=:7HB4cYgjJXFNkSEstX2oxi utMVYjNYKLktPSX8+DYqXhY8jHJq/YsbsIyocMVBtibGa86W3HrEwc/thfV8N67KufTMXx/kc lznD7vDCxu3hplVzswMHIuClxGRc1ZIDNOLi0ZT9HNV3Bq7eHiD3fe81sjEXAXpWBrP1Mr45s cwIGZgrYjYs9+CD7EzVUCYKLSiQVWl9oPPrRrQ7dquYklgKsLw8PB5dXMMpCXrBEy8OCL0v1H MLAnlqCQ2mNNGjlQCsV6AIoEP8dMwJNs1wsCQ4M8RgfasY7YMNSspNp+4wyaDhlsaLs6qhYs/ YJ15VMi55pG5S/09dPrEadzvioK7jzNZoEU/HxRGfzQweB0fx5aPGefs24XtCoZC1Z7eNQpzZ DQWrn1GDZE2JZ5jHFJN80jIf984kFx+hlQlZ/OCIricM9T1jhnEA4Hxa6FWE2YdNxCPPA2y3u t2TBi5pg3pBFxuQYTARZLN88/ZsN9bCqWiAEdPR7YDljnymnM6aSJ6n8Mn90SOomPCXujCGJ3 zZ/c3wfARVI2lmClJo3YUn5NiiF1fBZ1tIy3J4DgcTJjwXGttQRoz/7s/5zZgLqQt6f6e+3O7 Xziu3h8Fx3pyv4C5GqHF6+CczCbaT7w0xvfo5O9mqs1OV2u5Yo5H6hs1Uj9xOFWA19MWaXVC/ OZ9RH8qcM+P2T8WJVSZ7yZtJNuAtYVhmfJ+VnVx7WTuThOw5G8bycDV3RTRd/u+aikjM= |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Dave Airlie <airlied@redhat.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org |
| X-Original-Date | Mon, 2 May 2016 12:59:48 +0200 |
| X-Original-Message-ID | <1462186805-2211918-1-git-send-email-arnd@arndb.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1392126 |
Show key headers only | View raw
The sun4i drm driver uses the clk-provider interfaces, which are not available
when CONFIG_COMMON_CLK is disabled:
drivers/gpu/drm/sun4i/sun4i_dotclock.c:19:16: error: field 'hw' has incomplete type
struct clk_hw hw;
In file included from ../include/asm-generic/bug.h:13:0,
from ../arch/arm/include/asm/bug.h:59,
from ../include/linux/bug.h:4,
from ../include/linux/io.h:23,
from ../include/linux/clk-provider.h:14,
from ../drivers/gpu/drm/sun4i/sun4i_dotclock.c:13:
drivers/gpu/drm/sun4i/sun4i_dotclock.c: In function 'hw_to_dclk':
include/linux/kernel.h:831:48: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
...
This adds a Kconfig dependency to prevent the driver from being enabled
in this case.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
---
drivers/gpu/drm/sun4i/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig
index 99510e64e91a..a4b357db8856 100644
--- a/drivers/gpu/drm/sun4i/Kconfig
+++ b/drivers/gpu/drm/sun4i/Kconfig
@@ -1,6 +1,6 @@
config DRM_SUN4I
tristate "DRM Support for Allwinner A10 Display Engine"
- depends on DRM && ARM
+ depends on DRM && ARM && COMMON_CLK
depends on ARCH_SUNXI || COMPILE_TEST
select DRM_GEM_CMA_HELPER
select DRM_KMS_HELPER
--
2.7.0
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] drm/sun4i: add COMMON_CLK dependency Arnd Bergmann <arnd@arndb.de> - 2016-05-02 13:10 +0200 Re: [PATCH] drm/sun4i: add COMMON_CLK dependency Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-04 20:40 +0200
csiph-web