Groups > linux.kernel > #1392039

Re: [RESEND PATCH v2 00/13] eeprom: support for at24cs and at24mac

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v2 00/13] eeprom: support for at24cs and at24mac
Date	2016-05-02 09:50 +0200
Message-ID	<rugMa-7NK-15@gated-at.bofh.it> (permalink)
References	<rmPe2-21s-15@gated-at.bofh.it> <roFNh-1sa-19@gated-at.bofh.it> <rq1sm-VS-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> The read and write routines are quite complex and decide which
> operations to use (smbus or i2c) on the fly every time they're called.
> Why not split them into several simpler functions (each implementing a
> single way of talking to EEPROM) that would be assigned in probe()
> depending on the chip type and adapter's functionalities? Would you be
> willing to accept a series that does it?

That sounds like an interesting idea, in deed. I can't promise accepting
it yet obviously, because I haven't seen any code yet. But I think it is
worth pursuing. Maybe you could start hacking and keep going as long as
you think it is an improvement to the driver?

Thanks,

   Wolfram

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RESEND PATCH v2 00/13] eeprom: support for at24cs and at24mac Wolfram Sang <wsa@the-dreams.de> - 2016-05-02 09:50 +0200

csiph-web