Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1394069

Re: [PATCH 09/18] ASoC: sti: Update DT example to match the driver code

From Arnaud Pouliquen <arnaud.pouliquen@st.com>
Newsgroups linux.kernel
Subject Re: [PATCH 09/18] ASoC: sti: Update DT example to match the driver code
Date 2016-05-04 10:00 +0200
Message-ID <ruZSW-8fm-5@gated-at.bofh.it> (permalink)
References <rqkEG-8dU-7@gated-at.bofh.it> <rs8SK-6cK-7@gated-at.bofh.it> <rs9c6-6Eu-9@gated-at.bofh.it> <rs9F8-6Su-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


hello Arnd, peter,

On 04/26/2016 01:44 PM, Arnd Bergmann wrote:
> On Tuesday 26 April 2016 12:15:32 Peter Griffin wrote:
>>>
>>>> If not what would you recommend instead? 
>>>
>>> It's still not clear to me what that bit in the syscfg register
>>> is for. Given the error message about "sti-audio-clk-glue",
>>> I suspect that this is actually a clock controller and that
>>> it should be using the clock binding with a separate driver
>>> instead of manipulating the regmap directly from the audio driver.
>>
>> Luckily I do have the datasheet for the audio-glue sysconf register.
>>
>> It says: -
>>
>> [11:8] PCM_CLK_SEL: Selects the frequency synthesizer clock or the external
>> PCM clock for each channel.
>>
>> The driver only ever sets this to 1 which selects the frequency synthesizer
>> clock. So the bitfield of the register which the driver is using (PCM_CLK_SEL)
>> is a clock mux.
> 
> Ok, that sounds like it could be either a really simple clock driver
> with just a few lines, or integrated into an existing clock driver
> if you already have one for this syscon node.
> 
> 	Arnd
> 
FYI, Name of this glue is related to the register name. But it does not
concern only clock...
 This glue register is used to :
- select clock source ( clock framework or external clock from GPIO)
=> one bit field per IP instance (player->clk_sel)
- select uniperiph player IP instance for PCM out.
(http://www.spinics.net/lists/alsa-devel/msg49034.html)

Regards
Arnaud

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 09/18] ASoC: sti: Update DT example to match the driver  code Arnaud Pouliquen <arnaud.pouliquen@st.com> - 2016-05-04 10:00 +0200
  Re: [PATCH 09/18] ASoC: sti: Update DT example to match the driver code Arnd Bergmann <arnd@arndb.de> - 2016-05-04 11:10 +0200

csiph-web