Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support

From	Johan Hovold <johan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support
Date	2016-05-04 09:50 +0200
Message-ID	<ruZJf-8aG-11@gated-at.bofh.it> (permalink)
References	<ruqVd-dJ-49@gated-at.bofh.it> <ruqVd-dJ-47@gated-at.bofh.it> <ruDIL-4pf-19@gated-at.bofh.it> <ruGZZ-7ro-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 03, 2016 at 01:46:51PM +0200, Mathieu OTHACEHE wrote:
> > No, I was trying to say that the we should not attempt to load a
> > firmware on the "ti_usb-v%04x-p%04x.fw" format before loading the moxa
> > firmware.
> 
> For MTS devices (mts_*.fw) and for devices using generic firmware (ti_3410.fw
> and ti_5052.fw), ti_usb-v%04x-p%04x.fw loading is already failing.
> 
> So, I can patch the driver to request firmwares in this order :
> 
> 1. VID dependant (MTS and MOXA now)
> 2. ti_usb-v%04x-p%04x.fw format
> 3. Generic firmware
> 
> But, for generic firmware users, ti_usb-v%04x-p%04x.fw loading will
> still always fail ...
> 
> Or we can get rid of ti_usb-v%04x-p%04x.fw loading because no one has
> defined a firmware with this format in linux-firmware repository ?

Let's try to be conservative and not necessarily change the current
behaviour right away. Just make sure the Moxa firmware is loaded
directly, without fallback, and we can see about possibly cleaning up
the legacy behaviour later (in incremental patches that can easily be
reverted if anyone complains).

Thanks,
Johan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-05-02 20:40 +0200
  Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0  support Johan Hovold <johan@kernel.org> - 2016-05-03 10:20 +0200
    Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support Mathieu OTHACEHE <m.othacehe@gmail.com> - 2016-05-03 13:50 +0200
      Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0  support Johan Hovold <johan@kernel.org> - 2016-05-04 09:50 +0200

csiph-web