Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1393906

Re: [PATCH v2 5/5] vf610-soc: Add Vybrid SoC device tree binding documentation

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 5/5] vf610-soc: Add Vybrid SoC device tree binding documentation
Date 2016-05-04 04:40 +0200
Message-ID <ruUTg-3mC-11@gated-at.bofh.it> (permalink)
References <rugj7-7xc-5@gated-at.bofh.it> <rugj7-7xc-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, May 02, 2016 at 12:35:04PM +0530, Sanchayan Maity wrote:
> Add device tree binding documentation for Vybrid SoC.
> 
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  .../bindings/arm/freescale/fsl,vf610-soc.txt       | 35 ++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt
> new file mode 100644
> index 0000000..bdd95e8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt
> @@ -0,0 +1,35 @@
> +Vybrid System-on-Chip
> +---------------------
> +
> +Required properties:
> +
> +- #address-cells: must be 1
> +- #size-cells: must be 1
> +- compatible: "fsl,vf610-soc-bus", "simple-bus"

If this is a bus, put the file in bindings/bus/...

> +- interrupt-parent: phandle to the MSCM interrupt router node
> +- ranges
> +- fsl,rom-revision: phandle to the on-chip ROM node and address of rom
> +  revision register

Why is this needed here? Can't you search the tree for the ROM node and 
get this info.

> +- fsl,cpu-count: phandle to the MSCM CPU configuration node and address of
> +  CPU count register
> +- fsl,l2-size: phandle to the MSCM CPU configuration node and address of
> +  L2 cache size register
> +- nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1
> +- nvmem-cell-names: should contain string names "cfg0" and "cfg1"

How are all these properties used?

> +
> +Example:
> +
> +	soc {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "fsl,vf610-soc-bus", "simple-bus";
> +		interrupt-parent = <&mscm_ir>;
> +		ranges;
> +		fsl,rom-revision = <&ocrom 0x80>;
> +		fsl,cpu-count = <&mscm_cpucfg 0x2C>;
> +		fsl,l2-size = <&mscm_cpucfg 0x14>;
> +		nvmem-cells = <&ocotp_cfg0>, <&ocotp_cfg1>;
> +		nvmem-cell-names = "cfg0", "cfg1";
> +
> +		...
> +	};
> -- 
> 2.8.2
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 5/5] vf610-soc: Add Vybrid SoC device tree binding documentation Sanchayan Maity <maitysanchayan@gmail.com> - 2016-05-02 09:20 +0200
  Re: [PATCH v2 5/5] vf610-soc: Add Vybrid SoC device tree binding  documentation Rob Herring <robh@kernel.org> - 2016-05-04 04:40 +0200
    Re: [PATCH v2 5/5] vf610-soc: Add Vybrid SoC device tree binding  documentation maitysanchayan@gmail.com - 2016-05-05 10:40 +0200
      Re: [PATCH v2 5/5] vf610-soc: Add Vybrid SoC device tree binding documentation Rob Herring <robh@kernel.org> - 2016-05-09 19:20 +0200
        Re: [PATCH v2 5/5] vf610-soc: Add Vybrid SoC device tree binding  documentation Stefan Agner <stefan@agner.ch> - 2016-05-09 20:30 +0200
          Re: [PATCH v2 5/5] vf610-soc: Add Vybrid SoC device tree binding documentation Rob Herring <robh@kernel.org> - 2016-05-10 01:00 +0200
            Re: [PATCH v2 5/5] vf610-soc: Add Vybrid SoC device tree binding  documentation Stefan Agner <stefan@agner.ch> - 2016-05-10 03:20 +0200
              Re: [PATCH v2 5/5] vf610-soc: Add Vybrid SoC device tree binding documentation Rob Herring <robh@kernel.org> - 2016-05-11 05:30 +0200

csiph-web