Re: [PATCH] fix infoleak in wilc_wfi_cfgoperations

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fix infoleak in wilc_wfi_cfgoperations
Date	2016-05-04 01:10 +0200
Message-ID	<ruRC1-C0-3@gated-at.bofh.it> (permalink)
References	<ruQPE-8cw-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 03, 2016 at 06:17:28PM -0400, Kangjie Lu wrote:
> "mac" is an array allocated in stack without being initialized,
> and will be sent out via "nla_put". The dump_station() is supposed
> to initialize the mac address; otherwise, sensitive data in kernel
> stack will be leaked. To fix this, initialize it with memset or
> fill it with meaningful mac address.

"or"?  You just set it to zero, why not fix this correctly and put the
real address here?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fix infoleak in wilc_wfi_cfgoperations Kangjie Lu <kangjielu@gmail.com> - 2016-05-04 00:20 +0200
  Re: [PATCH] fix infoleak in wilc_wfi_cfgoperations Greg KH <gregkh@linuxfoundation.org> - 2016-05-04 01:10 +0200

csiph-web