[PATCH] fix infoleak in ioctl_cfg80211

From	Kangjie Lu <kangjielu@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] fix infoleak in ioctl_cfg80211
Date	2016-05-04 00:10 +0200
Message-ID	<ruQFX-866-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

"mac" is an array allocated in stack without being initialized,
and will be sent out via "nla_put". The dump_station() is supposed
to initialize the mac address; otherwise, sensitive data in kernel
stack will be leaked. To fix this, either initialize it (e.g.,
memset) or completely remove this dump_station().

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
 drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
index 12d1844..44a1582 100644
--- a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
@@ -2926,6 +2926,7 @@ static int cfg80211_rtw_dump_station(struct wiphy *wiphy,
 
 	/* TODO: dump scanned queue */
 
+	memset(mac, 0, ETH_ALEN);
 	return -ENOENT;
 }
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] fix infoleak in ioctl_cfg80211 Kangjie Lu <kangjielu@gmail.com> - 2016-05-04 00:10 +0200
  Re: [PATCH] fix infoleak in ioctl_cfg80211 Greg KH <gregkh@linuxfoundation.org> - 2016-05-04 01:10 +0200

csiph-web