Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1393787

Re: [PATCH net] bridge: fix igmp / mld query parsing

Path csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Stephen Hemminger <stephen@networkplumber.org>
Newsgroups linux.kernel
Subject Re: [PATCH net] bridge: fix igmp / mld query parsing
Date Tue, 03 May 2016 22:30:03 +0200
Message-ID <ruP7d-6xa-31@gated-at.bofh.it> (permalink)
References <ruP7c-6xa-15@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MCrRu55b8X8LsfK+2A7txlXcLhqFKk9YY0k3X6th/1k=; b=g6inrKbE1KyeOVsFJyIFVDt4d/oWN/ZK6b5Xlt1t7BNIimkijnfLXroXk177Fp1V/z kpTtCCGCdH8fHG4DOMzZ02B0OF1BY66/bxw4jwQTPWRCtmnOthvJkU0M2xYepIFNEUat BohN8YFFUxh5D8Ackeg2aKwz8qDwTSTjUJGTnUqWW6O8X8/dR17VvZPZBxxth3W/xCMd OEa0kmZXsOOcvYFYc71cnCQwMWdvhmd06k+CFEXgqiOnZiWsX4P+lzkRL5B/obL1QWMK /1bRThwV0DisJzD0+OMDzQ0EX8mJ6L6DTIZz+lNMiU3hwpM0941ZBwKrX/xRipxgua2j lkYQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MCrRu55b8X8LsfK+2A7txlXcLhqFKk9YY0k3X6th/1k=; b=YXXSlshCVVkuyjZUVYHazc6D7Ics5WVwCHJboNk7/0dl06sFqhxFXDdoGHfxq0ugd2 LXK+xvzgwxml9YZek6lHXboacAAJ4ODU0xWFigH6tsTfTcntrHjwcfakFj4C9z/Pw8q/ aYmHWRCScR4+8EL7p6ZheVC+tIse7iNfg+aRvQ2wfAl47Jsz6l/2xbJOoe8sC2K8RGkL 61i1G4YfPmZPPqowy1kAUXpzreBn/ro3HValNdMRUk76oLTvo9EnWPs4r13eNW4YnNzw eS+1ggldNNYbP9i1p0Ye8gza6i240bk/6/jSc2TUwd0RQdoWtZPInj22me1esyyZvFAW /N+Q==
X-Gm-Message-State AOPr4FVdQQI+EB+72x/Dqeon2p3oUHY/WeEovG6cOvK0dwmDY0uJh1VqDPMgYVVewrXJ/Q==
X-Received by 10.66.72.198 with SMTP id f6mr6552968pav.60.1462307170497; Tue, 03 May 2016 13:26:10 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Content-Transfer-Encoding 8BIT
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 13
Organization linux.* mail to news gateway
X-Original-Cc netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Simon Wunderlich <sw@simonwunderlich.de>
X-Original-Date Tue, 3 May 2016 13:26:23 -0700
X-Original-Message-ID <20160503132623.59cf54fb@xeon-e3>
X-Original-References <1462306734-4183-1-git-send-email-linus.luessing@c0d3.blue>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1393787

Show key headers only | View raw


On Tue,  3 May 2016 22:18:54 +0200
Linus Lüssing <linus.luessing@c0d3.blue> wrote:

> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 03661d9..7105cdf 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1271,6 +1271,7 @@ static int br_ip4_multicast_query(struct net_bridge *br,
>  	unsigned long max_delay;
>  	unsigned long now = jiffies;
>  	__be32 group;
> +	int offset = skb_transport_offset(skb);
shouldn't this be unsigned?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net] bridge: fix igmp / mld query parsing Linus Lüssing <linus.luessing@c0d3.blue> - 2016-05-03 22:30 +0200
  Re: [PATCH net] bridge: fix igmp / mld query parsing Stephen Hemminger <stephen@networkplumber.org> - 2016-05-03 22:30 +0200
    Re: [PATCH net] bridge: fix igmp / mld query parsing Linus Lüssing <linus.luessing@c0d3.blue> - 2016-05-04 17:00 +0200

csiph-web