Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1393786

Re: [PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix

Path csiph.com!goblin3!goblin1!goblin.stu.neva.ru!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Ross Zwisler <ross.zwisler@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix
Date Tue, 03 May 2016 22:30:02 +0200
Message-ID <ruP7c-6xa-17@gated-at.bofh.it> (permalink)
References <ruduW-4Wb-7@gated-at.bofh.it>
X-Original-To Hugh Dickins <hughd@google.com>
X-Extloop1 1
X-Ironport-Av E=Sophos;i="5.24,574,1455004800"; d="scan'208";a="696327881"
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.6.0 (2016-04-01)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 10
Organization linux.* mail to news gateway
X-Original-Cc Andrew Morton <akpm@linux-foundation.org>, Matthew Wilcox <willy@linux.intel.com>, Ross Zwisler <ross.zwisler@linux.intel.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org
X-Original-Date Tue, 3 May 2016 14:28:57 -0600
X-Original-Message-ID <20160503202857.GA3997@linux.intel.com>
X-Original-References <alpine.LSU.2.11.1605012108490.1166@eggly.anvils>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1393786

Show key headers only | View raw


On Sun, May 01, 2016 at 09:13:18PM -0700, Hugh Dickins wrote:
> radix_tree_locate_item() is often returning the wrong index, causing
> swapoff of shmem to hang because it cannot find the swap entry there.
> __locate()'s use of base is bogus, it adds an offset twice into index.
> 
> Signed-off-by: Hugh Dickins <hughd@google.com>

Thank you for the fix!

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix Hugh Dickins <hughd@google.com> - 2016-05-02 06:20 +0200
  [PATCH] radix-tree: add test for radix_tree_locate_item() Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-05-03 22:30 +0200
  Re: [PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-05-03 22:30 +0200

csiph-web