Re: [PATCH v2] net: mvneta: Remove superfluous SMP function call

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] net: mvneta: Remove superfluous SMP function call
Date	2016-05-03 21:30 +0200
Message-ID	<ruOb8-5Gk-19@gated-at.bofh.it> (permalink)
References	<rui1A-FW-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Anna-Maria Gleixner <anna-maria@linutronix.de>
Date: Mon,  2 May 2016 11:02:51 +0200

> Since commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out
> in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
> function calls are no longer required.
> 
> Replace smp_call_function_single() with a direct call to
> mvneta_percpu_enable() or mvneta_percpu_disable(). The functions do
> not require to be called with interrupts disabled, therefore the
> smp_call_function_single() calling convention is not preserved.
> 
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] net: mvneta: Remove superfluous SMP function call Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-05-02 11:10 +0200
  Re: [PATCH v2] net: mvneta: Remove superfluous SMP function call David Miller <davem@davemloft.net> - 2016-05-03 21:30 +0200

csiph-web