Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1393751

Re: [PATCH v2] x86/efi-bgrt: Switch all pr_err() to pr_notice() for invalid BGRT

Show all headers | View raw

On Tue, 03 May, at 01:47:04PM, Josh Boyer wrote:
> The promise of pretty boot splashes from firmware via BGRT was at
> best only that; a promise.  The kernel diligently checks to make
> sure the BGRT data firmware gives it is valid, and dutifully warns
> the user when it isn't.  However, it does so via the pr_err log
> level which seems unnecessary.  The user cannot do anything about
> this and there really isn't an error on the part of Linux to
> correct.
> 
> This lowers the log level by using pr_notice instead.  Users will
> no longer have their boot process uglified by the kernel reminding
> us that firmware can and often is broken when the 'quiet' kernel
> parameter is specified.  Ironic, considering BGRT is supposed to
> make boot pretty to begin with.
> 
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> ---
> 
> v2: Switch to using pr_notice instead of pr_debug
> 
>  arch/x86/platform/efi/efi-bgrt.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>

Applied. Thanks everyone!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] x86/efi-bgrt: Switch all pr_err() to pr_notice() for invalid BGRT Josh Boyer <jwboyer@fedoraproject.org> - 2016-05-03 19:50 +0200
  Re: [PATCH v2] x86/efi-bgrt: Switch all pr_err() to pr_notice() for  invalid BGRT Josh Triplett <josh@joshtriplett.org> - 2016-05-03 20:40 +0200
  Re: [PATCH v2] x86/efi-bgrt: Switch all pr_err() to pr_notice() for  invalid BGRT Matt Fleming <matt@codeblueprint.co.uk> - 2016-05-03 21:10 +0200
  Re: [PATCH v2] x86/efi-bgrt: Switch all pr_err() to pr_notice() for  invalid BGRT Josh Triplett <josh@joshtriplett.org> - 2016-05-03 22:20 +0200

csiph-web